Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case to verify artifacts repair at the Satellite side #14976

Merged
merged 5 commits into from
May 30, 2024
Merged

Add test case to verify artifacts repair at the Satellite side #14976

merged 5 commits into from
May 30, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented May 6, 2024

Problem Statement

Similar to #14884 which tests artifacts repair at the Capsule side (and we base on it here to use some helpers), this PR address similar testing at the Satellite side.

Solution

Similar to #14884 with some changes:

  • we don't want to clear all artifacts at the Satellite side since they may be used by other tests using the module-scoped fixtures, so I decided to push it into a separate module to run with a blank Satellite.
  • instead of parametrization for LCE-scoped repair we do parametrize for product-scoped repair

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_artifacts.py
nailgun: 1138
Katello:
katello: 10932

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels May 6, 2024
@vsedmik vsedmik self-assigned this May 6, 2024
@vsedmik vsedmik requested review from a team as code owners May 6, 2024 16:30
@vsedmik
Copy link
Contributor Author

vsedmik commented May 6, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_artifacts.py
nailgun: 1138

jyejare
jyejare approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from framework changes perspective, the changes looks good to me with minor comment to fix.

robottelo/host_helpers/capsule_mixins.py Outdated Show resolved Hide resolved
@vsedmik vsedmik force-pushed the artifacts-gone-sat branch from 5e07507 to 8a14804 Compare May 20, 2024 08:49
@vsedmik vsedmik requested a review from a team as a code owner May 20, 2024 08:49
@vsedmik
Copy link
Contributor Author

vsedmik commented May 20, 2024

rebased

@vsedmik vsedmik force-pushed the artifacts-gone-sat branch from 8a14804 to 88e7517 Compare May 20, 2024 09:22
@vsedmik
Copy link
Contributor Author

vsedmik commented May 20, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_artifacts.py
nailgun: 1138

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7009
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_artifacts.py --external-logging
Test Result : ================ 24 passed, 318 warnings in 1183.65s (0:19:43) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 20, 2024
@vsedmik vsedmik force-pushed the artifacts-gone-sat branch from 88e7517 to e74a2f3 Compare May 21, 2024 13:15
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 21, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented May 21, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_artifacts.py

@vsedmik
Copy link
Contributor Author

vsedmik commented May 21, 2024

Since we have the latest changes in snap 60, I have decided to change this test type from API to CLI so that we test both, hammer and API (called from hammer).

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7031
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_artifacts.py --external-logging
Test Result : ================ 24 passed, 213 warnings in 1181.27s (0:19:41) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 21, 2024
@vsedmik vsedmik force-pushed the artifacts-gone-sat branch from e74a2f3 to 331ca31 Compare May 29, 2024 09:39
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 29, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented May 29, 2024

Rebased on the recently merged #14884 plus updated CODEOWNERS.

@vsedmik
Copy link
Contributor Author

vsedmik commented May 29, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_artifacts.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7163
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_artifacts.py --external-logging
Test Result : ================ 24 passed, 214 warnings in 1235.75s (0:20:35) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 29, 2024
@sambible sambible merged commit 1b5784b into SatelliteQE:master May 30, 2024
11 checks passed
vsedmik added a commit to vsedmik/robottelo that referenced this pull request May 30, 2024
@vsedmik
Add test case to verify artifacts repair at the Satellite side (Satel…
645eb97 
…liteQE#14976)

* Add test case to verify artifacts repair at Capsule

* Merge yum/file and docker/AC into one test case

* Add test case to verify artifacts repair at Satellite

* Let the test run through CLI to test hammer too

* Update CODEOWNERS and lint fix
@vsedmik vsedmik mentioned this pull request May 30, 2024
Merged
sambible added a commit that referenced this pull request May 30, 2024
@vsedmik @sambible
[6.16.z] Add test case to verify artifacts repair at the Satellite si…
06f7c36 
…de (#15241)

Add test case to verify artifacts repair at the Satellite side (#14976)

* Add test case to verify artifacts repair at Capsule

* Merge yum/file and docker/AC into one test case

* Add test case to verify artifacts repair at Satellite

* Let the test run through CLI to test hammer too

* Update CODEOWNERS and lint fix

Co-authored-by: Samuel Bible <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Add test case to verify artifacts repair at the Satellite side (Satel…
0ecd87f 
…liteQE#14976)

* Add test case to verify artifacts repair at Capsule

* Merge yum/file and docker/AC into one test case

* Add test case to verify artifacts repair at Satellite

* Let the test run through CLI to test hammer too

* Update CODEOWNERS and lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant approved these changes

@sambible sambible sambible approved these changes

@jyejare jyejare jyejare approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsedmik @Satellite-QE @pondrejk @jyejare @sambible @vijaysawant