Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old CV UI tests #14989

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

sambible
Copy link
Contributor

@sambible sambible commented May 7, 2024

As part of CV Eval, it's time to clean up this old test file - these tests haven't passed in several versions, as this whole set of screens has been removed. Functionality to test the new CV UI is ongoing as part of eval work.

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 7, 2024
@sambible sambible requested a review from a team as a code owner May 7, 2024 20:14
@sambible sambible self-assigned this May 7, 2024
@lhellebr
Copy link
Contributor

lhellebr commented May 9, 2024

Since the change is in interface and not in functionality, shouldn't we keep the tests (perhaps mark them as stubs if they constantly fail) and rework this within airgun? Doesn't e.g. test test_positive_create_composite deserve to exist?

@vsedmik
Copy link
Contributor

vsedmik commented May 14, 2024

Since the change is in interface and not in functionality, shouldn't we keep the tests (perhaps mark them as stubs if they constantly fail) and rework this within airgun? Doesn't e.g. test test_positive_create_composite deserve to exist?

Do you propose stub it globally with pytestmark = [pytest.mark.stubbed] until the convertible tests are converted @lhellebr?

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep test which has relevant functionality exists within new UI, mark them as stubb & move into new ui tests (here /tests/foreman/ui/test_contentview.py) as test_contentview.py contains only 2 test cases.

@sambible sambible requested a review from a team as a code owner June 3, 2024 04:43
@sambible
Copy link
Contributor Author

sambible commented Jun 3, 2024

Agreeing with @lhellebr, stubbing is the more appropriate situation in this case.

@sambible sambible added the 6.16.z label Jun 3, 2024
@vsedmik vsedmik merged commit bf0544c into SatelliteQE:master Jun 4, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Mark all tests as stubbed

(cherry picked from commit bf0544c)
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Mark all tests as stubbed

(cherry picked from commit bf0544c)
@Gauravtalreja1
Copy link
Collaborator

@sambible PR title and commit message doesn't look similar, always try to keep them updated as per the changes

Gauravtalreja1 pushed a commit that referenced this pull request Jun 4, 2024
Remove old CV UI tests (#14989)

Mark all tests as stubbed

(cherry picked from commit bf0544c)

Co-authored-by: Samuel Bible <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Jun 4, 2024
Remove old CV UI tests (#14989)

Mark all tests as stubbed

(cherry picked from commit bf0544c)

Co-authored-by: Samuel Bible <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants