-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old CV UI tests #14989
Remove old CV UI tests #14989
Conversation
Since the change is in interface and not in functionality, shouldn't we keep the tests (perhaps mark them as stubs if they constantly fail) and rework this within airgun? Doesn't e.g. test |
Do you propose stub it globally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep test which has relevant functionality exists within new UI, mark them as stubb & move into new ui tests (here /tests/foreman/ui/test_contentview.py) as test_contentview.py contains only 2 test cases.
Agreeing with @lhellebr, stubbing is the more appropriate situation in this case. |
Mark all tests as stubbed (cherry picked from commit bf0544c)
Mark all tests as stubbed (cherry picked from commit bf0544c)
@sambible PR title and commit message doesn't look similar, always try to keep them updated as per the changes |
Remove old CV UI tests (#14989) Mark all tests as stubbed (cherry picked from commit bf0544c) Co-authored-by: Samuel Bible <[email protected]>
Remove old CV UI tests (#14989) Mark all tests as stubbed (cherry picked from commit bf0544c) Co-authored-by: Samuel Bible <[email protected]>
Mark all tests as stubbed
As part of CV Eval, it's time to clean up this old test file - these tests haven't passed in several versions, as this whole set of screens has been removed. Functionality to test the new CV UI is ongoing as part of eval work.