Add marker for case insensitive test collection by component and importance #15005

shweta83 · 2024-05-08T19:44:44Z

Problem Statement

We need case insensitive test collection component-wise

Solution

Added marker for component-wise test collection
result:
pytest tests/foreman/ --component auditlog
collected 5434 items / 5426 deselected / 8 selected

tests/foreman/api/test_audit.py ✓✓✓                                                                                                38% ███▊      
 tests/foreman/ui/test_audit.py ✓✓✓✓✓                                                                                              100% ██████████

=======================================================

Related Issues

shweta83 · 2024-05-08T19:45:46Z

trigger: test-robottelo
pytest: tests/foreman/ --component alternatecontentsources --collect-only

shweta83 · 2024-05-09T08:20:54Z

pytest tests/foreman/ --component auditlog

omkarkhatavkar · 2024-05-10T09:33:57Z

pytest_plugins/metadata_markers.py

@@ -191,8 +191,8 @@ def pytest_collection_modifyitems(items, config):
            # Add marker starting at smallest docstring scope
            # only add the mark if it hasn't already been applied at a lower scope
            doc_component = component_regex.findall(docstring)
-            if doc_component and 'component' not in item_mark_names:
-                item.add_marker(pytest.mark.component(doc_component[0]))
+            if doc_component and 'CaseComponent' not in item_mark_names:


why did you change the component to CaseComponent. we are adding component as marker to the test not CaseComponent. Or did I missed anything here ?

It searches for CaseComponent docstring in the test.

@jyejare I think it should be component right ? CaseComponent would not be a right marker to check as it it will not be there. As the we are adding the component marker.

@shweta83 Here @omkarkhatavkar is right we are adding a keypair of component=<somcomponent> to the the test item.

In below compoenent not in item_mark_names verifies that the component marker is not already added to the item.

if doc_component and 'component' not in item_mark_names:

jyejare · 2024-05-13T13:15:53Z

@shweta83 Please revisit the tests are not collecting. Please let me know if u need the help.

shweta83 · 2024-05-13T19:54:14Z

trigger: test-robottelo
pytest: pytest tests/foreman/ --component auditlog

shweta83 · 2024-05-14T06:03:27Z

@shweta83 Please revisit the tests are not collecting. Please let me know if u need the help.

It was working well on my local setup. I need to check what's the issue running on CI.

shweta83 · 2024-05-14T12:47:49Z

trigger: test-robottelo
pytest: tests/foreman/ --component auditlog

Satellite-QE · 2024-05-14T13:28:50Z

PRT Result

Build Number: 6919
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ --component auditlog --external-logging
Test Result : ======== 8 passed, 5442 deselected, 5563 warnings in 1140.10s (0:19:00) ========

shweta83 · 2024-05-14T13:32:07Z

@shweta83 Please revisit the tests are not collecting. Please let me know if u need the help.

Tests are collected as expected. I messed up in running previous PRT which failed the test collection.

rplevka · 2024-05-15T05:25:26Z

pytest_plugins/metadata_markers.py

@@ -164,7 +164,7 @@ def pytest_collection_modifyitems(items, config):
    # split the option string and handle no option, single option, multiple
    # config.getoption(default) doesn't work like you think it does, hence or ''
    importance = [i for i in (config.getoption('importance') or '').split(',') if i != '']


Mind doing the same to importance, while at it?

Suggested change

importance = [i for i in (config.getoption('importance') or '').split(',') if i != '']

importance = [i.lower() for i in (config.getoption('importance') or '').split(',') if i != '']

update the commit message

shweta83 · 2024-05-15T07:00:08Z

trigger: test-robottelo
pytest: tests/foreman/ --component auditlog

jyejare

ACK pending comments.

jyejare · 2024-05-15T07:14:52Z

pytest_plugins/metadata_markers.py

@@ -191,8 +191,8 @@ def pytest_collection_modifyitems(items, config):
            # Add marker starting at smallest docstring scope
            # only add the mark if it hasn't already been applied at a lower scope
            doc_component = component_regex.findall(docstring)
-            if doc_component and 'component' not in item_mark_names:
-                item.add_marker(pytest.mark.component(doc_component[0]))
+            if doc_component and 'CaseComponent' not in item_mark_names:


@shweta83 Here @omkarkhatavkar is right we are adding a keypair of component=<somcomponent> to the the test item.

In below compoenent not in item_mark_names verifies that the component marker is not already added to the item.

if doc_component and 'component' not in item_mark_names:

jyejare · 2024-05-15T07:15:45Z

pytest_plugins/metadata_markers.py

-            if doc_component and 'component' not in item_mark_names:
-                item.add_marker(pytest.mark.component(doc_component[0]))
+            if doc_component and 'CaseComponent' not in item_mark_names:
+                item.add_marker(pytest.mark.component(doc_component[0].lower()))
            doc_importance = importance_regex.findall(docstring)
            if doc_importance and 'importance' not in item_mark_names:
                item.add_marker(pytest.mark.importance(doc_importance[0]))


Suggested change

item.add_marker(pytest.mark.importance(doc_importance[0]))

item.add_marker(pytest.mark.importance(doc_importance[0].lower()))

Satellite-QE · 2024-05-15T07:29:01Z

PRT Result

Build Number: 6932
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ --component auditlog --external-logging
Test Result : ======== 8 passed, 5445 deselected, 5563 warnings in 900.26s (0:15:00) =========

shweta83 · 2024-05-17T07:19:47Z

trigger: test-robottelo
pytest: tests/foreman/ --component auditlog

Satellite-QE · 2024-05-17T07:45:28Z

PRT Result

Build Number: 6982
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ --component auditlog --external-logging
Test Result : ======== 8 passed, 5461 deselected, 5583 warnings in 1092.40s (0:18:12) ========

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

… and importance (#15233) Add marker for case insensitive test collection by component and importance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539) Co-authored-by: Shweta Singh <[email protected]>

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

… and importance (#15231) Add marker for case insensitive test collection by component and importance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539) Co-authored-by: Shweta Singh <[email protected]>

… and importance (#15232) Add marker for case insensitive test collection by component and importance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539) Co-authored-by: Shweta Singh <[email protected]>

…rtance (SatelliteQE#15005) Collect tests with case insensitive component marker

shweta83 requested a review from a team as a code owner May 8, 2024 19:44

github-actions bot assigned shweta83 May 8, 2024

shweta83 requested a review from jyejare May 8, 2024 19:45

omkarkhatavkar reviewed May 10, 2024

View reviewed changes

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 14, 2024

rplevka approved these changes May 15, 2024

View reviewed changes

shweta83 force-pushed the add_component_wise_marker_case_sensitive branch from 8b56245 to a7f2734 Compare May 15, 2024 06:57

shweta83 changed the title ~~Add marker for case insensitive test collection component-wise~~ Add marker for case insensitive test collection by component and importance May 15, 2024

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 15, 2024

jyejare requested changes May 15, 2024

View reviewed changes

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 15, 2024

Collect tests with case insensitive component marker

87ba96b

shweta83 force-pushed the add_component_wise_marker_case_sensitive branch from a7f2734 to 87ba96b Compare May 17, 2024 07:18

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 17, 2024

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 17, 2024

jyejare approved these changes May 27, 2024

View reviewed changes

jyejare merged commit 3fa1539 into SatelliteQE:master May 30, 2024
11 checks passed

github-actions bot pushed a commit that referenced this pull request May 30, 2024

Add marker for case insensitive test collection by component and impo…

375da3c

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

Satellite-QE mentioned this pull request May 30, 2024

[6.12.z] Add marker for case insensitive test collection by component and importance #15230

Closed

github-actions bot pushed a commit that referenced this pull request May 30, 2024

Add marker for case insensitive test collection by component and impo…

2d237a8

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

Satellite-QE mentioned this pull request May 30, 2024

[6.14.z] Add marker for case insensitive test collection by component and importance #15231

Merged

github-actions bot pushed a commit that referenced this pull request May 30, 2024

Add marker for case insensitive test collection by component and impo…

c9de01f

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

Satellite-QE mentioned this pull request May 30, 2024

[6.13.z] Add marker for case insensitive test collection by component and importance #15232

Merged

github-actions bot pushed a commit that referenced this pull request May 30, 2024

Add marker for case insensitive test collection by component and impo…

cb0170b

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

Satellite-QE mentioned this pull request May 30, 2024

[6.15.z] Add marker for case insensitive test collection by component and importance #15233

Merged

jyejare pushed a commit that referenced this pull request Jun 19, 2024

Add marker for case insensitive test collection by component and impo…

e34e943

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

jyejare pushed a commit that referenced this pull request Jun 19, 2024

Add marker for case insensitive test collection by component and impo…

b60b19b

…rtance (#15005) Collect tests with case insensitive component marker (cherry picked from commit 3fa1539)

jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024

Add marker for case insensitive test collection by component and impo…

7d3784d

…rtance (SatelliteQE#15005) Collect tests with case insensitive component marker

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add marker for case insensitive test collection by component and importance #15005

Add marker for case insensitive test collection by component and importance #15005

shweta83 commented May 8, 2024 •

edited

Loading

shweta83 commented May 8, 2024

shweta83 commented May 9, 2024

omkarkhatavkar May 10, 2024

shweta83 May 14, 2024

omkarkhatavkar May 15, 2024

jyejare May 15, 2024

jyejare commented May 13, 2024 •

edited

Loading

shweta83 commented May 13, 2024

shweta83 commented May 14, 2024

shweta83 commented May 14, 2024

Satellite-QE commented May 14, 2024

shweta83 commented May 14, 2024 •

edited

Loading

rplevka May 15, 2024

shweta83 commented May 15, 2024

jyejare left a comment

jyejare May 15, 2024

jyejare May 15, 2024

Satellite-QE commented May 15, 2024

shweta83 commented May 17, 2024

Satellite-QE commented May 17, 2024

	importance = [i for i in (config.getoption('importance') or '').split(',') if i != '']
	importance = [i.lower() for i in (config.getoption('importance') or '').split(',') if i != '']

	item.add_marker(pytest.mark.importance(doc_importance[0]))
	item.add_marker(pytest.mark.importance(doc_importance[0].lower()))

Add marker for case insensitive test collection by component and importance #15005

Add marker for case insensitive test collection by component and importance #15005

Conversation

shweta83 commented May 8, 2024 • edited Loading

Problem Statement

Solution

Related Issues

shweta83 commented May 8, 2024

shweta83 commented May 9, 2024

omkarkhatavkar May 10, 2024

Choose a reason for hiding this comment

shweta83 May 14, 2024

Choose a reason for hiding this comment

omkarkhatavkar May 15, 2024

Choose a reason for hiding this comment

jyejare May 15, 2024

Choose a reason for hiding this comment

jyejare commented May 13, 2024 • edited Loading

shweta83 commented May 13, 2024

shweta83 commented May 14, 2024

shweta83 commented May 14, 2024

Satellite-QE commented May 14, 2024

shweta83 commented May 14, 2024 • edited Loading

rplevka May 15, 2024

Choose a reason for hiding this comment

shweta83 commented May 15, 2024

jyejare left a comment

Choose a reason for hiding this comment

jyejare May 15, 2024

Choose a reason for hiding this comment

jyejare May 15, 2024

Choose a reason for hiding this comment

Satellite-QE commented May 15, 2024

shweta83 commented May 17, 2024

Satellite-QE commented May 17, 2024

shweta83 commented May 8, 2024 •

edited

Loading

jyejare commented May 13, 2024 •

edited

Loading

shweta83 commented May 14, 2024 •

edited

Loading