Updates for CV component eval #15043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
CherryPick
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
PRT-Passed
pondrejk
approved these changes
May 20, 2024
sambible
approved these changes
May 30, 2024
| @pytest.mark.parametrize('add_by_name', [True, False], ids=['name', 'id']) | ||
| def test_positive_add_custom_repo_by( | ||
| self, module_org, module_product, module_target_sat, add_by_name | ||
| ): | ||
| """Associate custom content to a content view with name |
There was a problem hiding this comment.
Probably want to update the docstring here, since I think reading this test can be a bit confusing now without a small amount of clarification. Really like the parametrization though, a nice way to clean up so much of the cruft in this test file :)
There was a problem hiding this comment.
Yeah, I will update it.
Satellite-QE
removed
the
PRT-Passed
sambible
approved these changes
May 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
* Few updates for CV component eval * Address comments (cherry picked from commit 47b9906)
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
* Few updates for CV component eval * Address comments (cherry picked from commit 47b9906)
This was referenced May 30, 2024
vsedmik
added a commit
that referenced
this pull request
May 30, 2024
Updates for CV component eval (#15043) * Few updates for CV component eval * Address comments (cherry picked from commit 47b9906) Co-authored-by: vsedmik <[email protected]>
vsedmik
added a commit
that referenced
this pull request
May 30, 2024
Updates for CV component eval (#15043) * Few updates for CV component eval * Address comments (cherry picked from commit 47b9906) Co-authored-by: vsedmik <[email protected]>
vsedmik
added a commit
to vsedmik/robottelo
that referenced
this pull request
May 31, 2024
* Few updates for CV component eval * Address comments
vsedmik
added a commit
that referenced
this pull request
May 31, 2024
Updates for CV component eval (#15043) * Few updates for CV component eval * Address comments
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
* Few updates for CV component eval * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
CV component eval proposes several changes to be done for content view tests.
Solution
This PR addresses some of them, mostly merges and some minor modifications. In particular:
test_positive_remove_cv_version_from_envis merged withtest_positive_remove_cv_version_from_multi_envtest_positive_promote_with_docker_repo_compositeis merged withtest_positive_promote_multiple_with_docker_repo_compositetest_positive_add_custom_repo_by_nameis parametrized for adding repo byidand incorrect BZ reference is removedtest_negative_update_with_nameanother test case where incorrect BZ reference is removedtest_positive_arbitrary_file_sync_over_capsuleis removed since it is already implemented in test_positive_sync_file_repotest_positive_restart_dynflow_publishandtest_positive_restart_dynflow_promoteare removed since they represent obsolete workflows nowadaysPRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k 'test_positive_add_custom_repo_by or test_positive_remove_cv_version_from_multi_env and not capsule'