Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] codecoverage bug2173870 #15080

Merged
merged 1 commit into from
May 16, 2024
Merged

[6.15.z] codecoverage bug2173870 #15080

merged 1 commit into from
May 16, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14273

Code coverage Bug2173870
Test Case : PASS

(robottelo_vv_615) [root@dell-per740-68-vm-05 robottelo]# pytest ./tests/foreman/virtwho/cli/test_esx_sca.py -k test_positive_post_hypervisors_with_fake_different_org_simultaneous --disable-pytest-warnings -q
.                                                                                                                                                                                                                                      [100%]
1 passed, 39 deselected, 23 warnings in 421.21s (0:07:01)
2024-03-06 23:04:35 - robottelo - WARNING - missing grid_url or session_id. unable to clean video files.

@yanpliu @web-flow
codecoverage bug2173870 (#14273)
bf50487 
* codecoverage bug2173870

* update the code for f-format and comments

* fix conflict and format issue

* update to fix conflict

* update to fix conflict

* use nested list comprehensions to replace loop

* replace double quotes with single quotes

* remove the duplicated \n

* Add the description of the methods

* Update the pre-commit for description

* Update robottelo/utils/virtwho.py

Co-authored-by: Gaurav Talreja <[email protected]>

* resolve conflict

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Gaurav Talreja <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c58fe8e)
@Satellite-QE Satellite-QE requested review from a team as code owners May 16, 2024 08:59
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 16, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit c19fb23 into 6.15.z May 16, 2024
13 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-c58fe8eac0e80aff35f49ccc48bcff67299102ad branch May 16, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@yanpliu yanpliu

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @yanpliu