Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Update tests to use fixed mask #15094

Merged
merged 1 commit into from
May 17, 2024
Merged

[6.15.z] Update tests to use fixed mask #15094

merged 1 commit into from
May 17, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15091

Problem Statement

Earlier subnet used fixed mask but it was changed to generate random mask in #13284 which was causing test failures with Start of IP range does not belong to subnet\n End of IP range does not belong to subnet

Solution

To resolve the issue, I am reverting the change in the module.

Related Issues

@Satellite-QE Satellite-QE requested a review from a team as a code owner May 17, 2024 08:15
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 17, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subnet.py

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 17, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6986
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subnet.py --external-logging
Test Result : ========== 21 passed, 18 deselected, 85 warnings in 872.79s (0:14:32) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 17, 2024
@Satellite-QE Satellite-QE merged commit 07ee7cb into 6.15.z May 17, 2024
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-d77637c4c110d66ed382fca64ecccb927192809a branch May 17, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shweta83 shweta83

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @shweta83