-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.14.z] Remove nailgun.entities imports in pytest_fixtures #15131
Merged
Gauravtalreja1
merged 1 commit into
6.14.z
from
cherry-pick-6.14.z-1e952b13f3ed098bf8063c52703e8a4065d79619
Jun 4, 2024
Merged
[6.14.z] Remove nailgun.entities imports in pytest_fixtures #15131
Gauravtalreja1
merged 1 commit into
6.14.z
from
cherry-pick-6.14.z-1e952b13f3ed098bf8063c52703e8a4065d79619
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satellite-QE
added
6.14.z
Introduced in or relating directly to Satellite 6.14
Auto_Cherry_Picked
Automatically cherrypicked PR using GHA
No-CherryPick
PR doesnt need CherryPick to previous branches
labels
May 21, 2024
|
PRT Result
|
Satellite-QE
added
the
PRT-Failed
Indicates that latest PRT run is failed for the PR
label
May 21, 2024
|
Waiting on #14966 |
PRT Result
|
(cherry picked from commit 1e952b1)
Gauravtalreja1
force-pushed
the
cherry-pick-6.14.z-1e952b13f3ed098bf8063c52703e8a4065d79619
branch
from
June 3, 2024 20:00
df59600
to
bf6dac8
Compare
|
1 similar comment
|
PRT Result
|
Gauravtalreja1
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, PRT failures look unrelated same as master PR
Gauravtalreja1
deleted the
cherry-pick-6.14.z-1e952b13f3ed098bf8063c52703e8a4065d79619
branch
June 4, 2024 11:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.14.z
Introduced in or relating directly to Satellite 6.14
Auto_Cherry_Picked
Automatically cherrypicked PR using GHA
No-CherryPick
PR doesnt need CherryPick to previous branches
PRT-Failed
Indicates that latest PRT run is failed for the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #15084
Problem Statement
SAT-22530
Uses of
nailgun.entities.${ENTITY}
should be replaced with${SATELLITE_INSTANCE}.api.${ENTITY}
.Solution
All fixtures under
pytest_fixtures/
now use nailgun through the satellite instance'sapi
attribute, and imports ofnailgun.entities
have been removed.Test results are the same before and after these changes.
with PR changes:
PRT job #6979:
master:
PRT job #6996:
Related Issues