Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fixed BZ from leapp tests and update RHEL8 to 8.10 #15137

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Remove fixed BZ from leapp tests and update RHEL8 to 8.10 #15137

merged 1 commit into from
Jul 3, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented May 22, 2024 •
edited
Loading

Problem Statement

BZ for leapp test has been fixed and in review state, so it can be removed.
Also, RHEL8 is updated to 8.10.

Solution

Removed the fixed BZ and reverted the target version change.

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner May 22, 2024 05:18
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 22, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7056
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 113 warnings, 1 error in 3226.31s (0:53:46) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 22, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7057
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 125 warnings, 1 error in 3222.59s (0:53:42) =============

@shweta83 shweta83 force-pushed the remove_leapp_BZ_docstring branch from 185e562 to 927ec65 Compare May 22, 2024 09:39
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7058
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 failed, 119 warnings, 1 error in 2609.00s (0:43:28) =============

@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7159
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 failed, 119 warnings, 1 error in 2816.43s (0:46:56) =============

@shweta83 shweta83 force-pushed the remove_leapp_BZ_docstring branch from 927ec65 to 465eef6 Compare May 29, 2024 10:16
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7162
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 122 warnings, 1 error in 3390.62s (0:56:30) =============

@shweta83 shweta83 force-pushed the remove_leapp_BZ_docstring branch from 465eef6 to b3562c2 Compare May 29, 2024 12:15
@shweta83 shweta83 mentioned this pull request May 29, 2024
Merged
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@shweta83 shweta83 force-pushed the remove_leapp_BZ_docstring branch from b3562c2 to 1c31e0b Compare May 29, 2024 12:28
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7168
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ================= 125 warnings, 2 errors in 2455.20s (0:40:55) =================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7165
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 124 warnings, 1 error in 3179.50s (0:52:59) =============

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7178
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ================= 130 warnings, 2 errors in 2587.80s (0:43:07) =================

@Gauravtalreja1
Copy link
Collaborator

@shweta83 is this PR still required, can you update this PR?

@shweta83 shweta83 force-pushed the remove_leapp_BZ_docstring branch from 1c31e0b to c436a35 Compare July 1, 2024 09:58
@shweta83
Copy link
Contributor Author

shweta83 commented Jul 1, 2024

@shweta83 is this PR still required, can you update this PR?

Yes, it is still required. We have support of 8.10 and 9.4 now.
Updated it.

@shweta83
Copy link
Contributor Author

shweta83 commented Jul 1, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label Jul 1, 2024
@shweta83 shweta83 changed the title Remove fixed BZ from leapp tests and revert source rhel version for leapp upgrade Remove fixed BZ from leapp tests and update RHEL8 to 8.10 Jul 1, 2024
@shweta83 shweta83 force-pushed the remove_leapp_BZ_docstring branch from c436a35 to 87c5924 Compare July 1, 2024 10:11
@shweta83
Copy link
Contributor Author

shweta83 commented Jul 1, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_leapp_client.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7587
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 119 warnings, 1 error in 3307.06s (0:55:07) =============

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7588
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_leapp_client.py --external-logging
Test Result : ============ 1 passed, 121 warnings, 1 error in 3086.71s (0:51:26) =============

@shweta83
Copy link
Contributor Author

shweta83 commented Jul 3, 2024 •
edited
Loading

One of the test is failing because of fixture scope issue, I am going to refactor the second test but the scope of PR is done so I would request to merge it this PR and I will take the refactor work in another PR.

@shweta83 shweta83 requested a review from Gauravtalreja1 July 3, 2024 10:57
@Gauravtalreja1 Gauravtalreja1 merged commit 6017746 into SatelliteQE:master Jul 3, 2024
8 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 3, 2024
@shweta83 @web-flow
Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (#15137)
d68d401 
Remove fixed BZ from leapp tests and update RHEL8 version to 8.10

(cherry picked from commit 6017746)
This was referenced Jul 3, 2024
Merged
Open
github-actions bot pushed a commit that referenced this pull request Jul 3, 2024
@shweta83 @web-flow
Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (#15137)
d571081 
Remove fixed BZ from leapp tests and update RHEL8 version to 8.10

(cherry picked from commit 6017746)
@Satellite-QE Satellite-QE mentioned this pull request Jul 3, 2024
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Jul 3, 2024
@Satellite-QE @shweta83
[6.15.z] Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (#…
e6cace0 
…15567)

Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (#15137)

Remove fixed BZ from leapp tests and update RHEL8 version to 8.10

(cherry picked from commit 6017746)

Co-authored-by: Shweta Singh <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Jul 3, 2024
@Satellite-QE @shweta83
[6.14.z] Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (#…
f3e6d09 
…15565)

Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (#15137)

Remove fixed BZ from leapp tests and update RHEL8 version to 8.10

(cherry picked from commit 6017746)

Co-authored-by: Shweta Singh <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Remove fixed BZ from leapp tests and update RHEL8 to 8.10 (SatelliteQ…
0e6fcb0 
…E#15137)

Remove fixed BZ from leapp tests and update RHEL8 version to 8.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhellebr lhellebr lhellebr left review comments

@vijaysawant vijaysawant vijaysawant requested changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shweta83 shweta83

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shweta83 @Satellite-QE @Gauravtalreja1 @lhellebr @vijaysawant