Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertions in file repo tests #15138

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix assertions in file repo tests #15138

merged 1 commit into from
May 22, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented May 22, 2024

Problem Statement

Several file-repo tests have been failing too long for a wrong assertion message.

Solution

Fix them all with this PR in a near term.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py -k 'upload_remove_srpm_content or upload_file_to_file_repo or remove_file or file_repo_contains_only_newer_file'

@vsedmik vsedmik added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 22, 2024
@vsedmik vsedmik requested a review from ogajduse May 22, 2024 10:04
@vsedmik vsedmik self-assigned this May 22, 2024
@vsedmik vsedmik requested a review from a team as a code owner May 22, 2024 10:04
@vsedmik
Copy link
Contributor Author

vsedmik commented May 22, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_repository.py -k 'upload_remove_srpm_content or upload_file_to_file_repo or remove_file or file_repo_contains_only_newer_file'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7059
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repository.py -k upload_remove_srpm_content or upload_file_to_file_repo or remove_file or file_repo_contains_only_newer_file --external-logging
Test Result : ========= 4 passed, 136 deselected, 172 warnings in 855.97s (0:14:15) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 22, 2024
@ogajduse ogajduse merged commit fe65df5 into SatelliteQE:master May 22, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2024
@vsedmik @web-flow
Fix assertions in file repo tests (#15138)
4966bd2 
(cherry picked from commit fe65df5)
github-actions bot pushed a commit that referenced this pull request May 22, 2024
@vsedmik @web-flow
Fix assertions in file repo tests (#15138)
89bec5c 
(cherry picked from commit fe65df5)
This was referenced May 22, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request May 22, 2024
@vsedmik @web-flow
Fix assertions in file repo tests (#15138)
a6e60a5 
(cherry picked from commit fe65df5)
@Satellite-QE Satellite-QE mentioned this pull request May 22, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Fix assertions in file repo tests (SatelliteQE#15138)
af2dd1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@ogajduse ogajduse ogajduse approved these changes

Assignees

@vsedmik vsedmik

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @ogajduse @jameerpathan111