[6.14.z] ui_session: return airgun session as a context manager #15155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `Satellite.ui_session()` context manager method, `airgun.session.Session()` is also a context manager and needs to be returned using the `with-yield` contruct, so the Session's `__enter__` and `__exit__` methods are executed. This fixes the problem where `Session.__exit__()` method was not called and thus screenshot was not taken and the browser window was not closed at the end of the test. Also the `except Exception: raise` part was removed as redundant. (cherry picked from commit 2618e01)
Satellite-QE
added
6.14.z
|
trigger: test-robottelo |
Satellite-QE
added
the
AutoMerge_Cherry_Picked
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
|
I've investigated the PRT failures and none is relevant to this patch. |
Gauravtalreja1
approved these changes
May 29, 2024
Gauravtalreja1
deleted the
cherry-pick-6.14.z-2618e01768c22921302da9dc3841809bd74e840b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #15050
Problem Statement
If a UI test is using the new session approach via
target_sat.ui_session(),the browser window is not closed at the end of the test.
Also the screenshot is not taken if the test fails.
Solution
Satellite.ui_session()method needs to return the airgunSessionas a context manager,so the
__exit__method is called, which handles screenshot capture and closing the browser window.