Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test timeout_to_kill #15162

Merged
merged 1 commit into from
Aug 1, 2024
Merged

test timeout_to_kill #15162

merged 1 commit into from
Aug 1, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

timeout to kill setting should cancel the rex job if it takes too long

Solution

adding test

Related Issues

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 23, 2024
@pondrejk pondrejk self-assigned this May 23, 2024
@pondrejk pondrejk requested a review from a team as a code owner May 23, 2024 15:02
@pondrejk
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout
theforeman:
    smart_proxy_remote_execution_ssh: 115

vsedmik
vsedmik approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely looks good, packit/PRT pending.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7096
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 2178.44s (0:36:18) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 23, 2024
@pondrejk
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout
theforeman:
    smart_proxy_remote_execution_ssh: 115

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7120
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 59 deselected, 67 warnings, 1 error in 1552.18s (0:25:52) ===========

@pondrejk
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout
theforeman:
    smart_proxy_remote_execution_ssh: 115

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7131
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 59 deselected, 67 warnings, 1 error in 1719.57s (0:28:39) ===========

@pondrejk
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout
theforeman:
    smart_proxy_remote_execution_ssh: 115

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7156
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 2155.09s (0:35:55) ==========

@pondrejk
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout
theforeman:
    smart_proxy_remote_execution_ssh: 115

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7196
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 2225.42s (0:37:05) ==========

@pondrejk
Copy link
Contributor Author

pondrejk commented Jun 3, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout
theforeman:
    smart_proxy_remote_execution_ssh: 115

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7245
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 2239.36s (0:37:19) ==========

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7356
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : =========== 59 deselected, 72 warnings, 1 error in 861.66s (0:14:21) ===========

@pondrejk
Copy link
Contributor Author

eh, prt won't pass due to the current registration issue, must await sn 62

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7401
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 1040.12s (0:17:20) ==========

@pondrejk
Copy link
Contributor Author

pondrejk commented Jul 3, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7636
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 1273.61s (0:21:13) ==========

@pondrejk
Copy link
Contributor Author

pondrejk commented Jul 8, 2024

hm, awaiting rubygem-smart_proxy_remote_execution_ssh-0.10.6 to land at stream, having the proper fix to the original issue, stay tuned

@pondrejk pondrejk requested a review from a team as a code owner July 8, 2024 12:23
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7804
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 1095.80s (0:18:15) ==========

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7808
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 942.15s (0:15:42) ===========

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7832
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 failed, 59 deselected, 72 warnings in 928.00s (0:15:27) ===========

pnovotny
pnovotny reviewed Jul 24, 2024
View reviewed changes
tests/foreman/cli/test_remoteexecution.py Outdated
:Verifies: SAT-25243
"""
client = rex_contenthost
command = r'for i in \`seq 160\`; do sleep \$i; done'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-blocking for the test functionality)
With sleep $i, the sleeps will be incremental, i.e. sleep 1; sleep 2; sleep 3, etc.
For sleeping for 160 seconds in 1-second ticks, running for run in {1..160}; do sleep 1; done will do the trick.

pnovotny
pnovotny approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My comment above is non-blocking.

@pondrejk
Copy link
Contributor Author

pondrejk commented Aug 1, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_remoteexecution.py -k timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7936
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_remoteexecution.py -k timeout --external-logging
Test Result : ========== 1 passed, 59 deselected, 72 warnings in 964.38s (0:16:04) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Aug 1, 2024
@pondrejk pondrejk merged commit 1628759 into SatelliteQE:master Aug 1, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
@pondrejk @web-flow
test timeout_to_kill (#15162)
9dec8f5 
(cherry picked from commit 1628759)
@Satellite-QE Satellite-QE mentioned this pull request Aug 1, 2024
Closed
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Aug 1, 2024
@pondrejk @damoore044
test timeout_to_kill (SatelliteQE#15162)
50b0aab
Gauravtalreja1 pushed a commit that referenced this pull request Aug 7, 2024
@pondrejk @Gauravtalreja1
test timeout_to_kill (#15162)
e4e45b8 
(cherry picked from commit 1628759)
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@pondrejk @jyejare
test timeout_to_kill (SatelliteQE#15162)
cfe9f03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik requested changes

@lhellebr lhellebr lhellebr approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@pondrejk pondrejk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pondrejk @Satellite-QE @pnovotny @lhellebr @vsedmik