Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify test_positive_ansible_custom_role to cover non-admin user scenario #15163

Merged
merged 1 commit into from
May 31, 2024
Merged

Modify test_positive_ansible_custom_role to cover non-admin user scenario #15163

merged 1 commit into from
May 31, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Currently, test_positive_ansible_custom_role covers only admin scenario, and as part of component audit its suggest to modify this test to cover non-admin user scenario

Solution

Parametrizing the existing test to cover both admin and non-admin user scenarios with few more changes

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 23, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this May 23, 2024
@Gauravtalreja1 Gauravtalreja1 requested review from a team as code owners May 23, 2024 17:14
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleREX::test_positive_ansible_custom_role

@Gauravtalreja1 Gauravtalreja1 mentioned this pull request May 23, 2024
Merged
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7097
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleREX::test_positive_ansible_custom_role --external-logging
Test Result : ================= 2 passed, 131 warnings in 1575.04s (0:26:15) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 23, 2024
shubhamsg199
shubhamsg199 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced May 30, 2024
Merged
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-non-admin-customrole branch from ce949c0 to 7edcddf Compare May 30, 2024 21:40
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleREX::test_positive_ansible_custom_role

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 30, 2024
@Gauravtalreja1 Gauravtalreja1 removed the request for review from a team May 30, 2024 21:42
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7220
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleREX::test_positive_ansible_custom_role --external-logging
Test Result : ================= 2 passed, 138 warnings in 1701.42s (0:28:21) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 30, 2024
pnovotny
pnovotny approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhamsg199 shubhamsg199 merged commit 9f38177 into SatelliteQE:master May 31, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Gauravtalreja1 @web-flow
Modify test_positive_ansible_custom_role to cover non-admin user scen…
5bea37b 
…ario (#15163)

Modify test_positive_ansible_custom_role to cover non-admin scenario

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9f38177)
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Gauravtalreja1 @web-flow
Modify test_positive_ansible_custom_role to cover non-admin user scen…
2de0abd 
…ario (#15163)

Modify test_positive_ansible_custom_role to cover non-admin scenario

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9f38177)
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@Gauravtalreja1 @web-flow
Modify test_positive_ansible_custom_role to cover non-admin user scen…
2256e9b 
…ario (#15163)

Modify test_positive_ansible_custom_role to cover non-admin scenario

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 9f38177)
@Satellite-QE Satellite-QE mentioned this pull request May 31, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-non-admin-customrole branch May 31, 2024 15:50
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Modify test_positive_ansible_custom_role to cover non-admin user scen…
28463c0 
…ario (SatelliteQE#15163)

Modify test_positive_ansible_custom_role to cover non-admin scenario

Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @pnovotny @shubhamsg199