-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Updating reporting tests to be sca compliant #15166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggestion for improvement.
Could you run PRT for some test using the setup_content
fixture? The test_positive_generate_job_report
could be a good candidate.
assert ( | ||
res[0]['Host'] == content_hosts[0].hostname and res[1]['Host'] == content_hosts[1].hostname | ||
) or ( | ||
res[0]['Host'] == content_hosts[1].hostname and res[1]['Host'] == content_hosts[0].hostname | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use sets to check if all hosts were reported.
assert ( | |
res[0]['Host'] == content_hosts[0].hostname and res[1]['Host'] == content_hosts[1].hostname | |
) or ( | |
res[0]['Host'] == content_hosts[1].hostname and res[1]['Host'] == content_hosts[0].hostname | |
) | |
assert {i['Host'] for i in res} == {i.hostname for i in content_hosts} |
0c6368e
to
e219ee3
Compare
trigger: test-robottelo |
PRT Result
|
…#15166) * Updating reporting component to sca only * addressing comments
SCA is now the default in 6.16. This PR is for updating all tests under the Reporting Component
SAT-24355