Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RHEL8 for container contenthost #15179

Merged
merged 1 commit into from
May 28, 2024
Merged

Use RHEL8 for container contenthost #15179

merged 1 commit into from
May 28, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented May 27, 2024 •
edited by Gauravtalreja1
Loading

Problem Statement

Some of our tests are failing to pull docker images with OCI artifacts using obsolete version of docker client provided by RHEL7 extras repo.
(see BZ#2262793)

Solution

Let's move forward to RHEL8 and newer version of podman/docker.
Proposed changes in this PR:

  1. Use RHEL8 with newer podman/docker client.
  2. Rescope container_contenthost fixture to module. This speeds up current tests from ~45 minutes to ~15 minutes. The downside is we need to ensure podman logout is performed on teardown (via request.addfinalizer).

Related Issues

With the new podman new issue was identified (which has not been hit with the old docker client): SAT-25328
Since the fix PR is up already, let's test it with packit.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_container_management.py
Katello:
    katello: 11006

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 27, 2024
@vsedmik vsedmik self-assigned this May 27, 2024
@vsedmik vsedmik requested review from a team as code owners May 27, 2024 07:37
@vsedmik
Copy link
Contributor Author

vsedmik commented May 27, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_container_management.py
Katello:
    katello: 11006

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7119
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_container_management.py --external-logging
Test Result : ================= 106 warnings, 4 errors in 2226.57s (0:37:06) =================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 27, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented May 27, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_container_management.py
nailgun: 1151
Katello:
    katello: 11006

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7126
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_container_management.py --external-logging
Test Result : ============ 1 failed, 3 passed, 53 warnings in 2652.99s (0:44:12) =============

@vsedmik vsedmik force-pushed the fix-container-content-host branch from 80ae35e to bc471d1 Compare May 27, 2024 10:23
@vsedmik
Copy link
Contributor Author

vsedmik commented May 27, 2024 

trigger: test-robottelo
pytest: tests/foreman/cli/test_container_management.py
nailgun: 1151
Katello:
    katello: 11006

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7129
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_container_management.py --external-logging
Test Result : ================= 4 passed, 55 warnings in 2587.32s (0:43:07) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 27, 2024
@pondrejk pondrejk merged commit 765e030 into SatelliteQE:master May 28, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@vsedmik @web-flow
Use RHEL8 for container contenthost (#15179)
251e1d7 
(cherry picked from commit 765e030)
@Satellite-QE Satellite-QE mentioned this pull request May 28, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@vsedmik @web-flow
Use RHEL8 for container contenthost (#15179)
f5e07de 
(cherry picked from commit 765e030)
This was referenced May 28, 2024
Merged
Closed
@vsedmik vsedmik mentioned this pull request May 29, 2024
Merged
vsedmik added a commit that referenced this pull request Jun 3, 2024
@Satellite-QE @vsedmik
[6.15.z] Use RHEL8 for container contenthost (#15202)
e7de38d 
Use RHEL8 for container contenthost (#15179)

(cherry picked from commit 765e030)

Co-authored-by: vsedmik <[email protected]>
vsedmik added a commit that referenced this pull request Jun 3, 2024
@Satellite-QE @vsedmik
[6.14.z] Use RHEL8 for container contenthost (#15203)
2a06c68 
Use RHEL8 for container contenthost (#15179)

(cherry picked from commit 765e030)

Co-authored-by: vsedmik <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Use RHEL8 for container contenthost (SatelliteQE#15179)
c67bc73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

Assignees

@vsedmik vsedmik

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @pondrejk @Griffin-Sullivan