Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] Fix content host finalizer #15195

Merged
merged 1 commit into from
May 28, 2024
Merged

[6.13.z] Fix content host finalizer #15195

merged 1 commit into from
May 28, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15186

Problem Statement

The test_positive_check_ignore_facts_os_setting fails in teardown with

failed on teardown with "TypeError: set_ignore_facts_for_os() missing 1 required positional argument: 'module_target_sat'"

Solution

This PR, hopefully.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting

@vsedmik @web-flow
Fix content host finalizer (#15186)
7597252 
(cherry picked from commit 121a3d8)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 28, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting
nailgun: 1151

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 28, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7135
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting --external-logging
Test Result : ========== 27 deselected, 36 warnings, 1 error in 1309.41s (0:21:49) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 28, 2024
vsedmik
vsedmik approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PRT failure is unrelated to this PR (related to default repos disable on AK).

@vsedmik vsedmik merged commit 68ac154 into 6.13.z May 28, 2024
15 of 18 checks passed
@vsedmik vsedmik deleted the cherry-pick-6.13.z-121a3d8d9be0b1b1d4829fa3b6539fb4718291e2 branch May 28, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@vsedmik vsedmik

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @vsedmik