Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix content host finalizer #15196

Merged
merged 1 commit into from
May 28, 2024
Merged

[6.15.z] Fix content host finalizer #15196

merged 1 commit into from
May 28, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15186

Problem Statement

The test_positive_check_ignore_facts_os_setting fails in teardown with

failed on teardown with "TypeError: set_ignore_facts_for_os() missing 1 required positional argument: 'module_target_sat'"

Solution

This PR, hopefully.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting

@vsedmik @web-flow
Fix content host finalizer (#15186)
bfde910 
(cherry picked from commit 121a3d8)
@Satellite-QE Satellite-QE requested a review from a team as a code owner May 28, 2024 12:56
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 28, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting
nailgun: 1151

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 28, 2024
@Satellite-QE Satellite-QE merged commit 01cfd35 into 6.15.z May 28, 2024
15 of 16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-121a3d8d9be0b1b1d4829fa3b6539fb4718291e2 branch May 28, 2024 13:07
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7134
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting --external-logging
Test Result : ========== 1 passed, 30 deselected, 44 warnings in 1113.58s (0:18:33) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @vsedmik