-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.13.z] Remove nailgun.entities imports in tests/foreman/cli #15217
Merged
tpapaioa
merged 1 commit into
SatelliteQE:6.13.z
from
tpapaioa:cli_tests_remove_entities_module_6_13_z
May 30, 2024
Merged
[6.13.z] Remove nailgun.entities imports in tests/foreman/cli #15217
tpapaioa
merged 1 commit into
SatelliteQE:6.13.z
from
tpapaioa:cli_tests_remove_entities_module_6_13_z
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapaioa
added
No-CherryPick
PR doesnt need CherryPick to previous branches
6.13.z
Introduced in or relating directly to Satellite 6.13
labels
May 29, 2024
tpapaioa
changed the title
[6.13.z] Cli tests remove entities module 6 13 z
[6.13.z] Remove nailgun.entities imports in tests/foreman/cli
May 29, 2024
|
PRT Result
|
Satellite-QE
added
the
PRT-Failed
Indicates that latest PRT run is failed for the PR
label
May 29, 2024
tpapaioa
force-pushed
the
cli_tests_remove_entities_module_6_13_z
branch
from
May 30, 2024 13:12
4634b36
to
5b3de64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.13.z
Introduced in or relating directly to Satellite 6.13
No-CherryPick
PR doesnt need CherryPick to previous branches
PRT-Failed
Indicates that latest PRT run is failed for the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
SAT-22500
Uses of
nailgun.entities.${ENTITY}
should be replaced with${SATELLITE_INSTANCE}.api.${ENTITY}
.Solution
All tests under tests/foreman/cli/ now use nailgun through the satellite instance's
api
attribute, and imports ofnailgun.entities
have been removed.