Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Remove nailgun.entities imports in tests/foreman/cli #15219

Merged

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented May 29, 2024

Problem Statement

SAT-22500

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All tests under tests/foreman/cli/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

@tpapaioa tpapaioa added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 29, 2024
@tpapaioa tpapaioa self-assigned this May 29, 2024
@tpapaioa tpapaioa changed the title [6.15.z] Cli tests remove entities module 6 15 z [6.15.z] Remove nailgun.entities imports in tests/foreman/cli May 29, 2024
@tpapaioa tpapaioa changed the base branch from master to 6.15.z May 29, 2024 18:03
@tpapaioa
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] tests/foreman/cli/test_contentview.py::TestContentView::test_positive_add_module_stream_filter_rule tests/foreman/cli/test_contentview.py::TestContentView::test_positive_add_rh_repo_by_id_and_create_filter tests/foreman/cli/test_discoveryrule.py::TestDiscoveryRuleRole::test_negative_delete_rule_with_non_admin_user tests/foreman/cli/test_discoveryrule.py::TestDiscoveryRuleRole::test_positive_crud_with_non_admin_user tests/foreman/cli/test_hostgroup.py::test_positive_create_with_multiple_entities_and_delete tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ldapauthsource.py::TestIPAAuthSource::test_positive_end_to_end_with_ipa[0] tests/foreman/cli/test_ldapauthsource.py::TestIPAAuthSource::test_usergroup_sync_with_refresh tests/foreman/cli/test_oscap.py::TestOpenScap::test_positive_associate_scap_policy_with_single_server tests/foreman/cli/test_repository.py::TestFileRepository::test_file_repo_contains_only_newer_file[0] tests/foreman/cli/test_repository.py::TestFileRepository::test_positive_upload_file_to_file_repo[0] tests/foreman/cli/test_repository.py::TestRepository::test_positive_create_with_auth_yum_repo[0] tests/foreman/cli/test_subscription.py::test_positive_delete_manifest_as_another_user tests/foreman/cli/test_syncplan.py::test_negative_synchronize_custom_product_past_sync_date tests/foreman/cli/test_syncplan.py::test_positive_info_enabled_field_is_displayed tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_daily_recurrence tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_future_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_past_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_products_future_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_weekly_recurrence tests/foreman/cli/test_syncplan.py::test_positive_synchronize_rh_product_future_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_rh_product_past_sync_date tests/foreman/cli/test_syncplan.py::test_positive_update_interval[0] tests/foreman/cli/test_syncplan.py::test_positive_update_sync_date tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_force_locked_template tests/foreman/cli/test_user.py::TestSshKeyInUser::test_positive_CRD_ssh_key tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0]

@tpapaioa tpapaioa force-pushed the cli_tests_remove_entities_module_6_15_z branch from 538f8f9 to d1dee47 Compare May 29, 2024 18:19
@tpapaioa tpapaioa force-pushed the cli_tests_remove_entities_module_6_15_z branch from d1dee47 to de6cd96 Compare May 29, 2024 19:17
@tpapaioa tpapaioa marked this pull request as ready for review May 29, 2024 19:17
@tpapaioa tpapaioa requested review from a team as code owners May 29, 2024 19:17
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7179
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] tests/foreman/cli/test_contentview.py::TestContentView::test_positive_add_module_stream_filter_rule tests/foreman/cli/test_contentview.py::TestContentView::test_positive_add_rh_repo_by_id_and_create_filter tests/foreman/cli/test_discoveryrule.py::TestDiscoveryRuleRole::test_negative_delete_rule_with_non_admin_user tests/foreman/cli/test_discoveryrule.py::TestDiscoveryRuleRole::test_positive_crud_with_non_admin_user tests/foreman/cli/test_hostgroup.py::test_positive_create_with_multiple_entities_and_delete tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ldapauthsource.py::TestIPAAuthSource::test_positive_end_to_end_with_ipa[0] tests/foreman/cli/test_ldapauthsource.py::TestIPAAuthSource::test_usergroup_sync_with_refresh tests/foreman/cli/test_oscap.py::TestOpenScap::test_positive_associate_scap_policy_with_single_server tests/foreman/cli/test_repository.py::TestFileRepository::test_file_repo_contains_only_newer_file[0] tests/foreman/cli/test_repository.py::TestFileRepository::test_positive_upload_file_to_file_repo[0] tests/foreman/cli/test_repository.py::TestRepository::test_positive_create_with_auth_yum_repo[0] tests/foreman/cli/test_subscription.py::test_positive_delete_manifest_as_another_user tests/foreman/cli/test_syncplan.py::test_negative_synchronize_custom_product_past_sync_date tests/foreman/cli/test_syncplan.py::test_positive_info_enabled_field_is_displayed tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_daily_recurrence tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_future_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_past_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_products_future_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_custom_product_weekly_recurrence tests/foreman/cli/test_syncplan.py::test_positive_synchronize_rh_product_future_sync_date tests/foreman/cli/test_syncplan.py::test_positive_synchronize_rh_product_past_sync_date tests/foreman/cli/test_syncplan.py::test_positive_update_interval[0] tests/foreman/cli/test_syncplan.py::test_positive_update_sync_date tests/foreman/cli/test_templatesync.py::TestTemplateSyncTestCase::test_positive_import_force_locked_template tests/foreman/cli/test_user.py::TestSshKeyInUser::test_positive_CRD_ssh_key tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] --external-logging
Test Result : =========== 1 failed, 26 passed, 421 warnings in 4184.40s (1:09:44) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 29, 2024
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on the Phoenix owned files.

@tpapaioa tpapaioa merged commit cf1b928 into SatelliteQE:6.15.z May 30, 2024
12 checks passed
@tpapaioa tpapaioa deleted the cli_tests_remove_entities_module_6_15_z branch May 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - Remove nailgun.entities imports in tests/foreman/cli
3 participants