Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Fix HTTP proxy teardown #15234

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15229

Problem Statement

In #14513 I overlooked that http_proxy can be even None which does not implement the delete() method so the teardown fails with

pytest_fixtures/component/http_proxy.py:32: in setup_http_proxy
    http_proxy.delete()
E   AttributeError: 'NoneType' object has no attribute 'delete'

Solution

Delete only existing objects.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_install_content_with_http_proxy

(cherry picked from commit 46b510f)
@Satellite-QE Satellite-QE added 6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 30, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_install_content_with_http_proxy

@vsedmik
Copy link
Contributor

vsedmik commented May 30, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_auto_attach_with_http_proxy

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 30, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7212
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_http_proxy.py -k test_positive_auto_attach_with_http_proxy --external-logging
Test Result : ========== 3 passed, 4 deselected, 215 warnings in 1548.28s (0:25:48) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 30, 2024
@Satellite-QE Satellite-QE merged commit 4160255 into 6.14.z May 30, 2024
18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.14.z-46b510fb74f818ff9bcd376684f89c70c25f2356 branch May 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants