Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun #15257

Merged
merged 1 commit into from
May 31, 2024
Merged

[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun #15257

merged 1 commit into from
May 31, 2024

Conversation

tpapaioa
Copy link
Contributor

Cherrypick of PR: #15220

Problem Statement

SAT-22504

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All tests under tests/foreman/longrun/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

@tpapaioa tpapaioa added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 31, 2024
@tpapaioa tpapaioa self-assigned this May 31, 2024
@tpapaioa tpapaioa force-pushed the longrun_tests_remove_entities_module_6_15_z branch from 98b0c9b to 1020e79 Compare May 31, 2024 14:11
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7236
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7] --external-logging
Test Result : ============ 1 failed, 125 warnings, 1 error in 1225.68s (0:20:25) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 31, 2024
@tpapaioa
[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
3136d64 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
@tpapaioa tpapaioa force-pushed the longrun_tests_remove_entities_module_6_15_z branch from 1020e79 to 3136d64 Compare May 31, 2024 16:52
@tpapaioa tpapaioa marked this pull request as ready for review May 31, 2024 16:52
@tpapaioa tpapaioa requested review from a team as code owners May 31, 2024 16:52
@tpapaioa tpapaioa merged commit 13c4edb into SatelliteQE:6.15.z May 31, 2024
10 checks passed
@tpapaioa tpapaioa deleted the longrun_tests_remove_entities_module_6_15_z branch May 31, 2024 17:01
@tpapaioa tpapaioa linked an issue May 31, 2024 that may be closed by this pull request
[Failed-AutoCherryPick] - Remove nailgun.entities imports in tests/foreman/longrun #15256
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tpapaioa tpapaioa

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - Remove nailgun.entities imports in tests/foreman/longrun
2 participants
@tpapaioa @Satellite-QE