Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] eol version check #15267

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13253

Problem Statement

This supplements tests for the EOL banner feature. The eol date for the version is defined in the satellite-lifecycle package (so that there is the same solution for connected and disconnected sats). This test aims to check the date in the package is correctly updated.

Solution

Comparing the date from the package with the date from the lifecycle api.

Keeping in draft state, as the EOL banner just got to 6.15, but not yet to older releases and the lifecycle api contains data only for released versions

Related Issues

satellite-jenkins MR 1185

(cherry picked from commit e65bda0)
@Satellite-QE Satellite-QE requested review from a team as code owners June 3, 2024 06:44
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 3, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_eol_banner.py

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 3, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7243
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_eol_banner.py --external-logging
Test Result : ================== 1 failed, 9 warnings in 711.72s (0:11:51) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 3, 2024
@pondrejk
Copy link
Contributor

pondrejk commented Jun 3, 2024

Heh, prt failure due to date mismatch, filed SAT-25522

@pondrejk
Copy link
Contributor

pondrejk commented Jun 3, 2024

Added BlockedBy statement, I suppose this should be considered mergeable given the prt failed with assertion error (uncovering the bug) and in other branches everything passed ok

@pondrejk pondrejk removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 3, 2024
@Satellite-QE Satellite-QE merged commit 0a3dc1c into 6.15.z Jun 3, 2024
10 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-e65bda0b00a5bd9d092b1469671ec0abe1fc77a7 branch June 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants