updated server.hostname validator for resolve rhel 8.10 formatting issue #15298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkarkhatavkar
force-pushed
the
fix_the_version_formatting
branch
from
3d2977b to
fc8cdbf
Compare
omkarkhatavkar
force-pushed
the
fix_the_version_formatting
branch
from
fc8cdbf to
40b7a75
Compare
omkarkhatavkar
changed the title
| @@ -10,7 +10,7 @@ | |||
| ), | |||
| ], | |||
| server=[ | |||
| Validator('server.hostname', default=''), | |||
| Validator('server.hostname', must_exist=True), | |||
There was a problem hiding this comment.
we don't have any field for settings.server.hostname in server.yml, we set it when assigning a xdist worker from settings.server.hostnames, so we can remove must_exist=True from this validator, right?
https://github.com/SatelliteQE/robottelo/blob/master/pytest_fixtures/core/xdist.py#L45
Gauravtalreja1
added
the
No-CherryPick
JacobCallahan
requested changes
Jun 4, 2024
There was a problem hiding this comment.
This field shouldn't be set by a user, it is set by the xdist alignment fixture as @Gauravtalreja1 pointed out
|
I dont think this is required as the solution was on the exporting env variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Currently the settings.server.hostname validator updates the settings.server.version.rhel_version from string value of
8.10to8.1Solution
Removed the validator settigns.server.hostname
Related Issues