Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Poll ncat tunnel pid #15335

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[6.15.z] Poll ncat tunnel pid #15335

merged 1 commit into from
Jun 6, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15056

Problem Statement

when checking the pid right after ncat startup
it could happen that no pid was found despite ncat being started

Solution

polling the ncat pid

Some tests using the feature

  • tests/foreman/cli/test_organization.py::test_positive_add_and_remove_capsules
  • tests/foreman/api/test_location.py::TestLocation::test_positive_create_update_and_remove_capsule

@dosas @web-flow
Poll ncat tunnel pid (#15056)
dcceb36 
when checking the pid right after ncat startup
it could happen that no pid was found despite ncat being started.
Polling solves this problem

(cherry picked from commit e918739)
@Satellite-QE Satellite-QE requested a review from a team as a code owner June 5, 2024 22:18
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 5, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_organization.py::test_positive_add_and_remove_capsules

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7304
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_organization.py::test_positive_add_and_remove_capsules --external-logging
Test Result : ================== 1 passed, 9 warnings in 667.05s (0:11:07) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 5, 2024
@lpramuk lpramuk merged commit 0a8b42a into 6.15.z Jun 6, 2024
16 checks passed
@lpramuk lpramuk deleted the cherry-pick-6.15.z-e918739b1e2d3614d3c2d9919a9728f21115e1c9 branch June 6, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpramuk lpramuk lpramuk approved these changes

Assignees

@dosas dosas

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @lpramuk @dosas