-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Customer Case] Applied Errata report with invalid errata #15378
[Customer Case] Applied Errata report with invalid errata #15378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:CaseImportance: High | ||
|
||
:BZ: 2176368 | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
:customerscenario: true | |
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we can assert these errors in output
undefined method `[]' for nil:NilClass"
undefined method `last' for nil:NilClass"
}, | ||
} | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think any other assertion can be implementated after generating errata report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this in chat, There are not any good ways to make an assertion here. All we need to test is that this report is generated. A failing tests is a good enough indicator here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small proposals, otherwise looks good.
:CaseImportance: High | ||
|
||
:BZ: 2176368 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:CaseImportance: High | |
:BZ: 2176368 | |
:BZ: 2176368 | |
:customerscenario: true |
No need to declare the CaseImportance again (same level as module-wide), but we should provide customerscenario
for customer cases.
activation_key = target_sat.api.ActivationKey( | ||
environment=function_lce, organization=function_org | ||
).create() | ||
cv = target_sat.api.ContentView(organization=function_org).create() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
activation_key = target_sat.api.ActivationKey( | |
environment=function_lce, organization=function_org | |
).create() | |
cv = target_sat.api.ContentView(organization=function_org).create() |
We could probably use function_ak_with_cv
fixture instead (and function_promoted_cv
it uses inside).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some issues with lce using that fixture, Test was failing, Lets just keep it how it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also found that fixture fails to setup as expected
trigger: test-robottelo |
PRT Result
|
…E#15378) * adding tests for invalid errata * addressing comments
Customer case automation for generating an applied errata report after applying an invalid errata.
All we need to test here is to make sure the report is generated without failure. However, because we never actually apply any errata, the report is an empty list. We can just assume it generated if there are no failures, but if anyone has any ideas on a potential assert that can be made im open to suggestions.