-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for all hosts page manage columns #15383
Test for all hosts page manage columns #15383
Conversation
PRT Result
|
trigger: test-robottelo |
PRT Result
|
trigger: test-robottelo |
PRT Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some clarifications needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it seems like the first part of this PR is a duplicate and the second was added by mistake and should be part of another PR.
I'll comment down here as well for additional visibility: This work, like other PRs around this All Hosts area, is to provide coverage for the currently in development "All Hosts" page. For those not familiar with the area, this will combine functionality from the existing Hosts page, and Content Hosts pages. Manage columns is a feature on this page, and on the Host page. Until the original Host page is retired completely, coverage for these two different areas will need to exist side by side, and in some cases, should and will look similar. |
28f71d3
to
f51ef49
Compare
Would it be better to have a single test, parametrized to use different Airgun entities, one for Hosts and one for All Hosts? Just a question, non-blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of nitpicks left.
This would be a more elegant solution, yes. The cases where the two tests look this similar though, are not that common. Seems worth investigating, though. (outside this PR) |
* Test for all hosts page manage columns * Add Verifies section to docstring Co-authored-by: vsedmik <[email protected]> * Fix Whitespace --------- Co-authored-by: vsedmik <[email protected]>
Problem Statement
Automation for 6.16 feature work as part of the All Hosts pt2 improvement.
Related Issues
SatelliteQE/airgun#1421 - airgun support PR
PRT
trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_columns'
airgun: 1421