Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for all hosts page manage columns #15383

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Jun 10, 2024

Problem Statement

Automation for 6.16 feature work as part of the All Hosts pt2 improvement.

Related Issues

SatelliteQE/airgun#1421 - airgun support PR

PRT

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_columns'
airgun: 1421

@sambible sambible added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jun 10, 2024
@sambible sambible requested a review from a team June 10, 2024 18:19
@sambible sambible self-assigned this Jun 10, 2024
@sambible sambible requested a review from a team as a code owner June 10, 2024 18:19
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7337
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_columns --external-logging
Test Result : ========== 1 failed, 50 deselected, 60 warnings in 806.67s (0:13:26) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 10, 2024
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_columns'
airgun: 1421

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7339
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_columns --external-logging
Test Result : ========== 1 failed, 50 deselected, 60 warnings in 818.58s (0:13:38) ===========

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_columns'
airgun: 1421

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7340
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_columns --external-logging
Test Result : ========== 1 passed, 50 deselected, 60 warnings in 835.34s (0:13:55) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 10, 2024
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some clarifications needed

tests/foreman/ui/test_host.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it seems like the first part of this PR is a duplicate and the second was added by mistake and should be part of another PR.

@sambible
Copy link
Contributor Author

I'll comment down here as well for additional visibility: This work, like other PRs around this All Hosts area, is to provide coverage for the currently in development "All Hosts" page. For those not familiar with the area, this will combine functionality from the existing Hosts page, and Content Hosts pages.

Manage columns is a feature on this page, and on the Host page. Until the original Host page is retired completely, coverage for these two different areas will need to exist side by side, and in some cases, should and will look similar.

@sambible sambible force-pushed the all-hosts-manage-columns branch from 28f71d3 to f51ef49 Compare June 12, 2024 15:47
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 12, 2024
@lhellebr
Copy link
Contributor

Would it be better to have a single test, parametrized to use different Airgun entities, one for Hosts and one for All Hosts? Just a question, non-blocking.

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of nitpicks left.

tests/foreman/ui/test_host.py Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
@sambible
Copy link
Contributor Author

Would it be better to have a single test, parametrized to use different Airgun entities, one for Hosts and one for All Hosts? Just a question, non-blocking.

This would be a more elegant solution, yes. The cases where the two tests look this similar though, are not that common. Seems worth investigating, though. (outside this PR)

@vsedmik vsedmik merged commit 28474f1 into SatelliteQE:master Jun 19, 2024
8 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
* Test for all hosts page manage columns

* Add Verifies section to docstring

Co-authored-by: vsedmik <[email protected]>

* Fix Whitespace

---------

Co-authored-by: vsedmik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants