Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo checksum with one supported #15426

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Update repo checksum with one supported #15426

merged 2 commits into from
Jun 18, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jun 17, 2024

Problem Statement

SHA1 is no longer supported by Pulp (see https://projects.theforeman.org/issues/37522) which renders one test failing. But the scenario seems still valid to me. It discovered a regression a few times ago, so I would like to keep it.

Solution

just run it with another supported checksum type.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_positive_checksum_sync

@vsedmik vsedmik added the No-CherryPick PR doesnt need CherryPick to previous branches label Jun 17, 2024
@vsedmik vsedmik self-assigned this Jun 17, 2024
@vsedmik vsedmik requested a review from a team as a code owner June 17, 2024 09:39
@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 17, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_positive_checksum_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7402
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_positive_checksum_sync --external-logging
Test Result : ========== 1 passed, 22 deselected, 37 warnings in 1411.14s (0:23:31) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 17, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 18, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 18, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_positive_checksum_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7414
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_positive_checksum_sync --external-logging
Test Result : ========== 1 passed, 22 deselected, 37 warnings in 1490.03s (0:24:50) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 18, 2024
@jameerpathan111 jameerpathan111 merged commit d636d43 into SatelliteQE:master Jun 18, 2024
11 checks passed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Update repo checksum with one supported (SatelliteQE#15426)
ffe930f 
* Update repo checksum with one supported

* Put checksums in variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@rmynar rmynar rmynar approved these changes

@synkd synkd synkd approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@ogajduse ogajduse ogajduse approved these changes

Assignees

@vsedmik vsedmik

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsedmik @Satellite-QE @ogajduse @jameerpathan111 @synkd @rmynar @damoore044