Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-client registration with capsule based on setting value #15428

Merged
merged 6 commits into from
Jun 28, 2024
Merged

CC-client registration with capsule based on setting value #15428

merged 6 commits into from
Jun 28, 2024

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

CC SAT-22048
Registration of the client system with Capsule is successful with the below error message.
HTTP error code 422: Validation failed: Content view environment content facets is invalid

Solution

This PR tests both the scenarios when settings "validate_host_lce_content_source_coherence" is set to Yes/No

Related Issues

N/A

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 17, 2024
@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch from 99114bf to 2bcefdc Compare June 18, 2024 12:42
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_host_registration_with_capsule'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7420
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_host_registration_with_capsule --external-logging
Test Result : ========= 1 failed, 87 deselected, 104 warnings in 1786.18s (0:29:46) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 18, 2024
@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch 3 times, most recently from d91ae87 to c0bcfdb Compare June 18, 2024 14:59
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jun 18, 2024
@vijaysawant

This comment was marked as duplicate.

Sign in to view
@Satellite-QE

This comment was marked as duplicate.

Sign in to view
@Satellite-QE

This comment was marked as duplicate.

Sign in to view
@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch from c0bcfdb to f5b556f Compare June 18, 2024 17:00
@vijaysawant

This comment was marked as duplicate.

Sign in to view
@Satellite-QE

This comment was marked as duplicate.

Sign in to view
@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch 2 times, most recently from 492a225 to 4047762 Compare June 19, 2024 04:49
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_positive_host_registration_with_capsule'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7438
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_host_registration_with_capsule --external-logging
Test Result : ========= 1 passed, 87 deselected, 104 warnings in 1744.89s (0:29:04) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 19, 2024
@vijaysawant vijaysawant marked this pull request as ready for review June 19, 2024 05:39
@vijaysawant vijaysawant requested a review from a team as a code owner June 19, 2024 05:39
shubhamsg199
shubhamsg199 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments

tests/foreman/cli/test_host.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_host.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_host.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_host.py Show resolved Hide resolved
omkarkhatavkar
omkarkhatavkar approved these changes Jun 19, 2024
View reviewed changes
Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor improvement

@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch from 92f7641 to ae78478 Compare June 27, 2024 12:12
@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch from ae78478 to 5e6dfe4 Compare June 27, 2024 12:20
@vijaysawant

This comment was marked as duplicate.

Sign in to view
1 similar comment
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_host_registration_with_capsule_using_content_coherence'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7559
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_host_registration_with_capsule_using_content_coherence --external-logging
Test Result : ========= 6 passed, 88 deselected, 934 warnings in 7853.23s (2:10:53) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 27, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7560
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_host_registration_with_capsule_using_content_coherence --external-logging
Test Result : ========= 6 passed, 88 deselected, 973 warnings in 7958.68s (2:12:38) ==========

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7563
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_host_registration_with_capsule_using_content_coherence --external-logging
Test Result : ===== 5 passed, 88 deselected, 998 warnings, 1 error in 7952.09s (2:12:32) =====

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Jun 27, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k 'test_host_registration_with_capsule_using_content_coherence'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7572
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_host_registration_with_capsule_using_content_coherence --external-logging
Test Result : ========= 6 passed, 88 deselected, 462 warnings in 2868.89s (0:47:48) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jun 28, 2024
@vijaysawant vijaysawant force-pushed the cc-client-system-registration-with-capsule branch from e3f99a4 to 099be8d Compare June 28, 2024 12:41
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 28, 2024
@damoore044 damoore044 merged commit d6d012b into SatelliteQE:master Jun 28, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
@vijaysawant @web-flow
CC-client registration with capsule based on setting value (#15428)
923d34b 
* client registration with capsule based on setting value

* client registration with capsule based on setting value, fixed error

* worked on minor review comments

* bypass assertion for rhel7 version

* resolve issue, which bypass rhel7 version

* used module level fixture instead of function level

(cherry picked from commit d6d012b)
@Satellite-QE Satellite-QE mentioned this pull request Jun 28, 2024
Merged
@vijaysawant vijaysawant mentioned this pull request Jun 28, 2024
Merged
@Satellite-QE Satellite-QE mentioned this pull request Jun 28, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vijaysawant @jyejare
CC-client registration with capsule based on setting value (Satellite…
4207888 
…QE#15428)

* client registration with capsule based on setting value

* client registration with capsule based on setting value, fixed error

* worked on minor review comments

* bypass assertion for rhel7 version

* resolve issue, which bypass rhel7 version

* used module level fixture instead of function level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik left review comments

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

@damoore044 damoore044 damoore044 approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vijaysawant @Satellite-QE @omkarkhatavkar @Gauravtalreja1 @vsedmik @shubhamsg199 @damoore044