Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Modify ansible variable test to cover non-admin scenario #15429

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15416

Problem Statement

Currently, ansible variable test covers only admin scenario, and as part of component audit its suggest to modify this test to cover non-admin user scenario as well, and delete the duplicate test which test create delete

Solution

  • Parametrizing the existing test to cover both admin and non-admin user scenarios with few more fixes
  • Deleting the test test_positive_create_and_delete_variable which tests create delete which is covered already in other test.

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit ec71335)
@Satellite-QE Satellite-QE added 6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 17, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_create_delete_variable_with_overrides

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 17, 2024
@Satellite-QE Satellite-QE merged commit 127de46 into 6.13.z Jun 17, 2024
16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.13.z-ec713355a21061be9ff536b6b0ce6ca36f0836ed branch June 17, 2024 14:41
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7410
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt::test_positive_create_delete_variable_with_overrides --external-logging
Test Result : ================= 2 passed, 36 warnings in 1153.97s (0:19:13) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants