Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changes in broker stderr handling #15442

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Jun 18, 2024

Problem Statement

Since version 0.5 broker accesses the list and
decodes the stderr

https://github.com/SatelliteQE/broker/blob/master/broker/helpers.py#L512

Solution

Simple code adaptation

Related Issues

#15394

relevant tests

tests/foreman/api/test_location.py::TestLocation::test_positive_create_update_and_remove_capsule
tests/foreman/cli/test_organization.py::test_positive_add_and_remove_capsules

@dosas dosas requested a review from a team as a code owner June 18, 2024 09:35
@dosas dosas added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 18, 2024
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

@JacobCallahan
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_location.py -k test_positive_create_update_and_remove_capsule

@dosas
Copy link
Collaborator Author

dosas commented Jun 20, 2024

@JacobCallahan Are the failing PRT tests related to the change?

@ogajduse
Copy link
Member

It seems that it hit a pipeline error. Let's run it once again.

@ogajduse
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_location.py -k test_positive_create_update_and_remove_capsule

@ogajduse
Copy link
Member

Something is going on in our pipeline. I asked @omkarkhatavkar for help. I will post updates in the coming days.

@ogajduse
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_location.py::TestLocation::test_positive_create_update_and_remove_capsule

1 similar comment
@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: tests/foreman/api/test_location.py::TestLocation::test_positive_create_update_and_remove_capsule

@ogajduse
Copy link
Member

Thanks for the patch, @dosas!

@ogajduse ogajduse merged commit 08f5b26 into SatelliteQE:master Jun 25, 2024
10 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants