-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase search rate for syncplan polling #15452
Increase search rate for syncplan polling #15452
Conversation
The timediff was increased to 5 minutes. On 'fast' UIs this can lead to poll timeouts. Increasing the search rate to 15 fixes this: 15 * 20 / 60 = 5
Can one of the admins verify this patch? |
Can you please describe the issue you are seeing using the current implementation? Please also expand on what you mean by fast UI. I would like to understand better where you are coming from. |
Okay. As discussed in the related PR #15172 the sync interval was changed form 3 to 5 minutes. Allegedly because the navigation was (sometimes?) to slow and the task was executed before the polling (slow UI). After I merged these changes in the downstream tests I had the issue that the polling went into a timeout because it stopped before the task was executed (fast UI). So the fix is to increase the search rate so that the five minute mark is always reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dosas Thank you for explaining it. All clear now. LGTM
(cherry picked from commit 8752ca9)
(cherry picked from commit 8752ca9)
Problem Statement
The timediff was increased to 5 minutes.
On 'fast' UIs this can lead to poll timeouts.
Solution
Increasing the search rate to 15 fixes this:
15 * 20 / 60 = 5
Related Issues
#15172
Relevant tests
tests/foreman/ui/test_syncplan.py::test_positive_synchronize_custom_product_custom_cron_real_time
tests/foreman/ui/test_syncplan.py::test_positive_synchronize_custom_product_custom_cron_past_sync_date