Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer Assertions in test context rather than in helper #15461

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Jun 20, 2024

Problem Statement

The assertion failure in the installer test helper blocks the installation of the satellite itself in the installer test and mainly in sanity testing making all the other tests unable to reach out to the satellite as it's not installed.

Solution

  • Removing the assertion from helper function as its already under the context of the test assertions.
  • Now we don't unblock installer execution and the rest of the tests should validate the build from sanity execution.

Related Issues

Refer build sanity failure of 6.15.2 and the related thread in the automation slack channel.

@jyejare jyejare requested a review from a team as a code owner June 20, 2024 10:43
@jyejare jyejare added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 Urgent Priority Get this done now Easy Fix :) Easiest Fix to review and quick merge request. labels Jun 20, 2024
Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving assert into new sanity test

pytest_fixtures/core/sat_cap_factory.py Show resolved Hide resolved
@lpramuk lpramuk merged commit 8d1d525 into SatelliteQE:master Jun 20, 2024
13 checks passed
jyejare added a commit to jyejare/robottelo that referenced this pull request Jun 20, 2024
jyejare added a commit to jyejare/robottelo that referenced this pull request Jun 20, 2024
jyejare added a commit to jyejare/robottelo that referenced this pull request Jun 20, 2024
jyejare added a commit to jyejare/robottelo that referenced this pull request Jun 20, 2024
jyejare added a commit to jyejare/robottelo that referenced this pull request Jun 20, 2024
lpramuk pushed a commit that referenced this pull request Jun 20, 2024
…15461) (#15466)

Installer Assertions in test context rather than in helper (#15461)
lpramuk pushed a commit that referenced this pull request Jun 20, 2024
…15461) (#15467)

Installer Assertions in test context rather than in helper (#15461)
jyejare added a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. Urgent Priority Get this done now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants