-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer Assertions in test context rather than in helper #15461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyejare
added
CherryPick
PR needs CherryPick to previous branches
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
Urgent Priority
Get this done now
Easy Fix :)
Easiest Fix to review and quick merge request.
labels
Jun 20, 2024
lpramuk
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving assert into new sanity test
jameerpathan111
approved these changes
Jun 20, 2024
lpramuk
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
jyejare
added a commit
to jyejare/robottelo
that referenced
this pull request
Jun 20, 2024
jyejare
added a commit
to jyejare/robottelo
that referenced
this pull request
Jun 20, 2024
jyejare
added a commit
to jyejare/robottelo
that referenced
this pull request
Jun 20, 2024
jyejare
added a commit
that referenced
this pull request
Jun 20, 2024
jyejare
added a commit
to jyejare/robottelo
that referenced
this pull request
Jun 20, 2024
jyejare
added a commit
to jyejare/robottelo
that referenced
this pull request
Jun 20, 2024
lpramuk
pushed a commit
that referenced
this pull request
Jun 20, 2024
lpramuk
pushed a commit
that referenced
this pull request
Jun 20, 2024
jyejare
added a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
CherryPick
PR needs CherryPick to previous branches
Easy Fix :)
Easiest Fix to review and quick merge request.
Urgent Priority
Get this done now
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The assertion failure in the installer test helper blocks the installation of the satellite itself in the installer test and mainly in sanity testing making all the other tests unable to reach out to the satellite as it's not installed.
Solution
Related Issues
Refer build sanity failure of 6.15.2 and the related thread in the automation slack channel.