Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt api reporttemplate tests to removal of host statuses #15960

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Adapt api reporttemplate tests to removal of host statuses #15960

merged 1 commit into from
Sep 6, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Aug 19, 2024

Problem Statement

The following system related host status were removed (https://docs.theforeman.org/3.10/Release_Notes/index-katello.html#_removed_system_purpose_related_host_statuses)

Subscription Status (this column has also been removed from the All Hosts table)
System Purpose Status
SLA Status
Role Status
Usage Status
Addon Status

Solution

adapt and unify expected values

Related tests

tests/foreman/api/test_reporttemplates.py::test_positive_generate_report_filter
tests/foreman/api/test_reporttemplates.py::test_positive_generate_report_nofilter

@dosas dosas requested a review from a team as a code owner August 19, 2024 12:12
@dosas dosas added the No-CherryPick PR doesnt need CherryPick to previous branches label Aug 19, 2024
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

@pondrejk pondrejk added 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 6, 2024
@pondrejk
Copy link
Contributor

pondrejk commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_reporttemplates.py -k test_positive_generate_report_filter

@pondrejk pondrejk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 6, 2024
@pondrejk
Copy link
Contributor

pondrejk commented Sep 6, 2024

manual prt trigger passed (8503)
tests/foreman/api/test_reporttemplates.py . [100%]

@pondrejk pondrejk merged commit b1ff8a3 into SatelliteQE:master Sep 6, 2024
11 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
@dosas @web-flow
Adapt api reporttemplate tests to removal of host statuses (#15960)
f6dfba6 
https://docs.theforeman.org/3.10/Release_Notes/index-katello.html#_removed_system_purpose_related_host_statuses
(cherry picked from commit b1ff8a3)
@Satellite-QE Satellite-QE mentioned this pull request Sep 6, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@dosas @jyejare
Adapt api reporttemplate tests to removal of host statuses (Satellite…
4b97c86 
…QE#15960)

https://docs.theforeman.org/3.10/Release_Notes/index-katello.html#_removed_system_purpose_related_host_statuses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

Assignees

@dosas dosas

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dosas @omkarkhatavkar @pondrejk