Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli host tests by applying pattern from similar test #15984

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Aug 20, 2024

Problem Statement

Test failing with TypeError: list indices must be integers or slices, not str

Solution

Apply fix form similar test (see also #11544)

Related tests

tests/foreman/cli/test_host.py::test_negative_edit_parameter_by_non_admin_user
tests/foreman/cli/test_host.py::test_positive_view_parameter_by_non_admin_user

@dosas dosas requested a review from a team as a code owner August 20, 2024 09:41
@dosas dosas added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Aug 20, 2024
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_negative_edit_parameter_by_non_admin_user

@pondrejk
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_negative_edit_parameter_by_non_admin_user

@pondrejk
Copy link
Contributor

passing in local checkout

@pondrejk pondrejk merged commit fcac818 into SatelliteQE:master Aug 21, 2024
8 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
dosas added a commit that referenced this pull request Sep 4, 2024
pondrejk pushed a commit that referenced this pull request Sep 5, 2024
…6026)

Fix cli host tests by applying pattern from similar test (#15984)

(cherry picked from commit fcac818)

Co-authored-by: dosas <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants