Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update occurences of repo option in register to use repo_data #16215

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update occurences of repo option in register to use repo_data #16215

merged 1 commit into from
Sep 4, 2024

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Sep 4, 2024

Problem Statement

Host registration command have new option "repo-data" which combines "repo" and "repo-gpg-key-url" option(both are deprecated now).
Follow-up on #16090

Solution

Updated hammer host registration method to accept new option and removed older deprecated options.
Created a test to test repo-data option

Related Issues

@shweta83 shweta83 requested a review from a team as a code owner September 4, 2024 19:11
@shweta83
Copy link
Contributor Author

shweta83 commented Sep 4, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_ansible.py -k test_positive_read_facts_with_filter

@shweta83 shweta83 added TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 4, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8474
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_ansible.py -k test_positive_read_facts_with_filter --external-logging
Test Result : ========= 2 passed, 16 deselected, 137 warnings in 1217.34s (0:20:17) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 4, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit 622f090 into SatelliteQE:master Sep 4, 2024
12 of 13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@shweta83 @web-flow
Update occurences of repo option in register to use repo_data (#16215)
3b4c1b3 
(cherry picked from commit 622f090)
@Satellite-QE Satellite-QE mentioned this pull request Sep 4, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Update occurences of repo option in register to use repo_data (Satell…
d21f860 
…iteQE#16215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shweta83 shweta83

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @Satellite-QE @Gauravtalreja1