Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add teardown condition to execute other test seamlessly #16219

Merged
merged 1 commit into from
Sep 5, 2024
Merged

add teardown condition to execute other test seamlessly #16219

merged 1 commit into from
Sep 5, 2024

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

Did not delete expired manifest from the organization after it's use in test test_negative_check_katello_reimport, when test unable to execute succesfully it then it was creating problem with other test defined in UI > test_subscription.py
Both test uses same xdist worker to run.

Solution

With the help of finalizer, delete manifest and organization from test case after it's use, it will depends on test execution result.

Related Issues

N/A

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 5, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner September 5, 2024 11:06
@vijaysawant
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py -k 'test_negative_check_katello_reimport'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8481
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subscription.py -k test_negative_check_katello_reimport --external-logging
Test Result : ========== 1 passed, 10 deselected, 19 warnings in 807.03s (0:13:27) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 5, 2024
@vijaysawant vijaysawant requested a review from a team September 5, 2024 15:27
@Gauravtalreja1 Gauravtalreja1 merged commit 88e23d9 into SatelliteQE:master Sep 5, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
@vijaysawant @web-flow
add teardown condition to execute other test seamlessly (#16219)
983d465 
(cherry picked from commit 88e23d9)
@Satellite-QE Satellite-QE mentioned this pull request Sep 5, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vijaysawant @jyejare
add teardown condition to execute other test seamlessly (SatelliteQE#…
73fa864 
…16219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vijaysawant @Satellite-QE @pondrejk @Gauravtalreja1 @ColeHiggins2