Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] Fix cli contenthost tests #16226

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15991

Problem Statement

if a key's value is zero the key is not displayed anymore but removed.

Solution

adapt assertion to check absence of key

Related tests

tests/foreman/cli/test_contentview.py::TestContentView::test_positive_remove_repository_by_id
tests/foreman/cli/test_contentview.py::TestContentView::test_positive_remove_repository_by_name
tests/foreman/cli/test_contentview.py::TestContentView::test_positive_republish_after_content_removed
tests/foreman/cli/test_contentview.py::TestContentView::test_positive_remove_lce_by_id_and_reassign_ak
tests/foreman/cli/test_contentview.py::TestContentView::test_positive_remove_component_by_name
tests/foreman/cli/test_contentview.py::TestContentView::test_positive_create_composite_with_component_ids

if a key's value is zero the key is not displayed anymore
but removed.

(cherry picked from commit 706ae54)
@Satellite-QE Satellite-QE requested a review from a team as a code owner September 5, 2024 14:18
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 5, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py -k test_positive_remove_repository_by_id

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 5, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8486
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py -k test_positive_remove_repository_by_id --external-logging
Test Result : ========= 1 passed, 117 deselected, 126 warnings in 663.33s (0:11:03) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 5, 2024
@Satellite-QE Satellite-QE merged commit f7756cc into 6.16.z Sep 5, 2024
16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-706ae54002bb9f79661e03857b4dc9d9c7311ef2 branch September 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants