Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder and improve clone test to match docs #16683

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rmynar
Copy link
Contributor

@rmynar rmynar commented Oct 16, 2024

Added coverage for SAT-27907.

Reordered steps to match documentation - Pulp content has to be copied to target machine before the satellite-clone is executed.

Added steps that occupy source satellite userids on target satellite server to check that satellite-clone changes ownership and permissions.

@rmynar rmynar added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 16, 2024
@rmynar rmynar self-assigned this Oct 16, 2024
@rmynar rmynar marked this pull request as ready for review October 16, 2024 09:21
@rmynar rmynar requested a review from a team as a code owner October 16, 2024 09:21
Comment on lines 101 to 102
f'sshpass -p "{SSH_PASS}" rsync -e "ssh -o StrictHostKeyChecking=no" --archive --partial --progress --compress '
f'/var/lib/pulp root@{sat_ready_rhel.hostname}:/var/lib/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say:

# rsync --archive --partial --progress --compress \
/var/lib/pulp/ target_server.example.com:/var/lib/pulp/

So this should be:

Suggested change
f'sshpass -p "{SSH_PASS}" rsync -e "ssh -o StrictHostKeyChecking=no" --archive --partial --progress --compress '
f'/var/lib/pulp root@{sat_ready_rhel.hostname}:/var/lib/'
f'sshpass -p "{SSH_PASS}" rsync -e "ssh -o StrictHostKeyChecking=no" --archive --partial --progress --compress '
f'/var/lib/pulp/ root@{sat_ready_rhel.hostname}:/var/lib/'

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the re-ordering is correct, just a nitpick on the rsync command to be exactly as in docs (rsync is picky about trailing slashes)

@rmynar rmynar force-pushed the coverage-sat-27907 branch from 22ede62 to 9a8b2aa Compare October 16, 2024 13:18
@rmynar
Copy link
Contributor Author

rmynar commented Oct 16, 2024

trigger: test-robottelo
pytest: tests/foreman/destructive/test_clone.py::test_positive_clone_backup

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8983
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_clone.py::test_positive_clone_backup --external-logging
Test Result : ================ 4 passed, 578 warnings in 10533.34s (2:55:33) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 16, 2024
@LadislavVasina1
Copy link
Contributor

@rmynar don't you want to add AutoMerge_Cherry_Picked label to this PR?

@jameerpathan111 jameerpathan111 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Oct 17, 2024
@rmynar rmynar force-pushed the coverage-sat-27907 branch from 9a8b2aa to eecd3b1 Compare October 17, 2024 10:01
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 17, 2024
@pondrejk pondrejk merged commit 4fb0042 into SatelliteQE:master Oct 21, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
improve and reorder clone test to match docs

(cherry picked from commit 4fb0042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants