Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New improvements and fixes to pytest req updates plugin #16692

Merged
merged 3 commits into from
Oct 25, 2024
Merged

New improvements and fixes to pytest req updates plugin #16692

merged 3 commits into from
Oct 25, 2024

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Oct 17, 2024 •
edited
Loading

Problem Statement

  • UV package manager support was not available
  • Broker requirement not being handled well as optional backends/installations were activated
  • pyYMAL requirement was not handled well
  • airgun and nailgun git installations were not handled well as they don't have versions to compare

Solution

  • UV package manager support is added
  • Broker handled for optional backends/installations
  • pyYMAL requirement now handled
  • airgun and nailgun git installations are handled and now wont be reported as deviation but would be updated

Logs:

# pytest -s --collect-only tests/foreman/api/test_product.py --update-all-reqs
============= test session starts ===============
platform darwin -- Python 3.12.2, pytest-8.3.3, pluggy-1.5.0
Using Python 3.12.2 environment at /Users/jyejare/venv/uv_robo_master
 Updated https://github.com/SatelliteQE/airgun.git (98c53e4)
 Updated https://github.com/SatelliteQE/nailgun.git (08bbd9a)                                                                                                                                                         Resolved 83 packages in 2.83s
Audited 83 packages in 0.15ms
Required requirements are updated.
Optional Requirements are up to date.
To update requirements, run the pytest with '--update-required-reqs' OR '--update-all-reqs' option.

@jyejare jyejare requested a review from a team as a code owner October 17, 2024 10:07
@jyejare jyejare marked this pull request as draft October 17, 2024 10:08
@jyejare jyejare force-pushed the fix_reqs_plugin branch 2 times, most recently from da7b4a2 to f6163f8 Compare October 18, 2024 16:35
@jyejare jyejare marked this pull request as ready for review October 18, 2024 16:35
@jyejare jyejare changed the title New fixes and improvements to pytest req updates plugin New improvements and fixes to pytest req updates plugin Oct 19, 2024
@jyejare jyejare force-pushed the fix_reqs_plugin branch 3 times, most recently from 47a3c80 to ff9d60b Compare October 19, 2024 04:12
@jyejare jyejare requested review from a team as code owners October 19, 2024 04:12
@jyejare jyejare force-pushed the fix_reqs_plugin branch 7 times, most recently from 96bb143 to 625c74b Compare October 21, 2024 10:23
JacobCallahan
JacobCallahan requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor phrasing. ack on the concept though

pytest_plugins/requirements/req_updater.py Outdated Show resolved Hide resolved
pytest_plugins/requirements/req_updater.py Outdated Show resolved Hide resolved
@jyejare jyejare mentioned this pull request Oct 23, 2024
Open
@jyejare jyejare force-pushed the fix_reqs_plugin branch 2 times, most recently from 51839b6 to e88ad9a Compare October 23, 2024 09:45
@jyejare
Copy link
Member Author

jyejare commented Oct 23, 2024

@JacobCallahan Please revisit, all comments are fixed.

1 similar comment
@jyejare
Copy link
Member Author

jyejare commented Oct 23, 2024

@JacobCallahan Please revisit, all comments are fixed.

@jyejare jyejare added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 23, 2024
@jyejare jyejare merged commit 59f2b4a into SatelliteQE:master Oct 25, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
@jyejare @web-flow
New improvements and fixes to pytest req updates plugin (#16692)
8c38b5d 
* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
@jyejare @web-flow
New improvements and fixes to pytest req updates plugin (#16692)
90076df 
* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)
This was referenced Oct 25, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
@jyejare @web-flow
New improvements and fixes to pytest req updates plugin (#16692)
9fdddfd 
* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
@jyejare @web-flow
New improvements and fixes to pytest req updates plugin (#16692)
5cc5a4e 
* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)
This was referenced Oct 25, 2024
Merged
Merged
jyejare added a commit that referenced this pull request Oct 25, 2024
@Satellite-QE @jyejare
[6.14.z] New improvements and fixes to pytest req updates plugin (#16785
930ea60 
)

New improvements and fixes to pytest req updates plugin (#16692)

* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)

Co-authored-by: Jitendra Yejare <[email protected]>
jyejare added a commit that referenced this pull request Oct 25, 2024
@Satellite-QE @jyejare
[6.16.z] New improvements and fixes to pytest req updates plugin (#16786
0bce384 
)

New improvements and fixes to pytest req updates plugin (#16692)

* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)

Co-authored-by: Jitendra Yejare <[email protected]>
jyejare added a commit that referenced this pull request Oct 25, 2024
@Satellite-QE @jyejare
[6.15.z] New improvements and fixes to pytest req updates plugin (#16787
235f594 
)

New improvements and fixes to pytest req updates plugin (#16692)

* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)

Co-authored-by: Jitendra Yejare <[email protected]>
jyejare added a commit that referenced this pull request Oct 25, 2024
@Satellite-QE @jyejare
[6.13.z] New improvements and fixes to pytest req updates plugin (#16788
d0be110 
)

New improvements and fixes to pytest req updates plugin (#16692)

* New fixes and improvements to pytest req updates plugin

* Pre commit fixes

* More granular reporting

(cherry picked from commit 59f2b4a)

Co-authored-by: Jitendra Yejare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@jyejare jyejare

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyejare @JacobCallahan