Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for capsule content counts granularity #16697

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 17, 2024

Problem Statement

In 6.17 capsule content counts will be updated separately for each CV when it is synced to the capsule and we should have a test case to cover that.

Solution

This PR just adds such a test case.

PRT test Cases example

Requires Katello/katello#11176

trigger: test-robottelo
pytest: tests/foreman/cli/test_capsulecontent.py -k test_positive_content_counts_granularity

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 17, 2024
@vsedmik vsedmik self-assigned this Oct 17, 2024
@vsedmik vsedmik requested a review from a team as a code owner October 17, 2024 16:22
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 17, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_capsulecontent.py -k test_positive_content_counts_granularity
Katello:
    katello: 11176

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9005
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_capsulecontent.py -k test_positive_content_counts_granularity --external-logging
Test Result : ========== 1 passed, 27 deselected, 40 warnings in 3001.14s (0:50:01) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Oct 17, 2024
@vsedmik vsedmik marked this pull request as draft October 18, 2024 08:46
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 18, 2024

Turning into draft until we resolve https://issues.redhat.com/browse/SAT-28743 and discuss the expected behaviour on step +c where we hit the issue from other side.

@vsedmik vsedmik force-pushed the cli-ccc-granularity branch from 36fcd95 to d2f11a5 Compare October 30, 2024 11:02
@vsedmik vsedmik force-pushed the cli-ccc-granularity branch from d2f11a5 to 557dd89 Compare December 3, 2024 11:55
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 3, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_capsulecontent.py -k test_positive_content_counts_granularity

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9510
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_capsulecontent.py -k test_positive_content_counts_granularity --external-logging
Test Result : ========== 1 passed, 27 deselected, 44 warnings in 1386.46s (0:23:06) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 3, 2024
@vsedmik vsedmik marked this pull request as ready for review December 3, 2024 12:32
@ogajduse ogajduse requested a review from Copilot December 11, 2024 14:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (1)

tests/foreman/cli/test_capsulecontent.py:128

  • [nitpick] The function name _dictionarize_counts is ambiguous. Consider renaming it to something more descriptive like convert_counts_to_named_dict.
def _dictionarize_counts(data):

tests/foreman/cli/test_capsulecontent.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants