Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AK for errata UI tests #16707

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix AK for errata UI tests #16707

merged 1 commit into from
Oct 23, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 18, 2024 •
edited
Loading

Problem Statement

Since 6.17 Activation keys create and update ops need both - CV and LCE, or none of them.
This new reality broke a couple of tests.

Solution

This PR fixes UI errata tests accordingly. Others will follow.

Related Issues

https://issues.redhat.com/browse/SAT-28577

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 18, 2024
@vsedmik vsedmik self-assigned this Oct 18, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 18, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9030
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : =========== 6 failed, 1624 warnings, 12 errors in 8748.93s (2:25:48) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 18, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9032
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ====== 3 failed, 3 passed, 1173 warnings, 12 errors in 2653.76s (0:44:13) ======

@vsedmik vsedmik force-pushed the fix-ak-cve-validation branch from d794ec9 to 7ffce0a Compare October 21, 2024 07:50
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 21, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9034
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ====== 1 failed, 15 passed, 1713 warnings, 2 errors in 5247.71s (1:27:27) ======

@vsedmik vsedmik force-pushed the fix-ak-cve-validation branch from 7ffce0a to 91ef416 Compare October 21, 2024 15:31
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 21, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9059
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ================ 18 passed, 2668 warnings in 8902.69s (2:28:22) ================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Oct 21, 2024
@vsedmik vsedmik force-pushed the fix-ak-cve-validation branch from 91ef416 to 7256d4a Compare October 22, 2024 08:34
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 22, 2024
@vsedmik vsedmik changed the title Make module_ak an empty entity Fix AK for errata UI tests Oct 22, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 22, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

@vsedmik vsedmik force-pushed the fix-ak-cve-validation branch from 7256d4a to 4991ebe Compare October 22, 2024 08:51
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9071
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : ================ 18 passed, 1881 warnings in 6026.53s (1:40:26) ================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 22, 2024
@vsedmik vsedmik marked this pull request as ready for review October 22, 2024 10:36
@vsedmik vsedmik requested a review from a team as a code owner October 22, 2024 10:36
@vsedmik vsedmik requested review from damoore044 and removed request for a team October 22, 2024 10:36
damoore044
damoore044 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work for this change to AK / CVE

shweta83
shweta83 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsedmik vsedmik merged commit 9fbd054 into SatelliteQE:master Oct 23, 2024
10 checks passed
@vsedmik vsedmik deleted the fix-ak-cve-validation branch October 23, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 approved these changes

@damoore044 damoore044 damoore044 approved these changes

Assignees

@vsedmik vsedmik

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @shweta83 @damoore044