Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AK for errata CLI tests #16742

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 22, 2024

Problem Statement

Since 6.17 Activation keys create and update ops need both - CV and LCE, or none of them.
This new reality broke a couple of tests.

Solution

This PR fixes CLI errata tests accordingly. Others will follow.

Related Issues

https://issues.redhat.com/browse/SAT-28577

PRT test Cases example

There is another fix in katello still missing in stream snap 76 (--name is required when --id is provided for AK update), that's why I used packit/PRT bellow

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py
Katello:
    katello: 11166

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 22, 2024
@vsedmik vsedmik self-assigned this Oct 22, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 22, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9090
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_errata.py --external-logging
Test Result : =========== 14 passed, 469 warnings, 26 errors in 2498.01s (0:41:38) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 22, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 22, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py
Katello:
    katello: 11166

@vsedmik vsedmik changed the title Fix ak CVE validation cli Fix AK for errata CLI tests Oct 22, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9097
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_errata.py --external-logging
Test Result : ============ 39 passed, 725 warnings, 1 error in 4401.25s (1:13:21) ============

@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 23, 2024

The single PRT error was broker.providers.ansible_tower.JobExecutionError on teardown. Unrelated to this PR.

@vsedmik vsedmik marked this pull request as ready for review October 23, 2024 07:31
@vsedmik vsedmik requested review from a team as code owners October 23, 2024 07:31
@ogajduse ogajduse merged commit 1300483 into SatelliteQE:master Nov 1, 2024
11 of 12 checks passed
@vsedmik vsedmik deleted the fix-ak-cve-validation-cli branch November 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants