Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACS validation messages #16752

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Oct 24, 2024

Problem Statement

  1. ACS validation messages have changed (just the case).
  2. The original or was used in the beginnings when it differed in stream and z-streams and we wanted both to pass. Now only the second one is appropriate.

Solution

Update the messages to what we have in stream today.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_acs.py -k 'test_negative_check_custom_rhui_validations or test_negative_check_simplified_validations'

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Oct 24, 2024
@vsedmik vsedmik self-assigned this Oct 24, 2024
@vsedmik vsedmik requested a review from a team as a code owner October 24, 2024 09:22
@vsedmik
Copy link
Contributor Author

vsedmik commented Oct 24, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_acs.py -k 'test_negative_check_custom_rhui_validations or test_negative_check_simplified_validations'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9137
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_acs.py -k test_negative_check_custom_rhui_validations or test_negative_check_simplified_validations --external-logging
Test Result : ========== 4 passed, 10 deselected, 48 warnings in 576.01s (0:09:36) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 24, 2024
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jameerpathan111 jameerpathan111 merged commit 830f27e into SatelliteQE:master Oct 24, 2024
11 checks passed
@vsedmik vsedmik deleted the fix-acs-cli branch October 25, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants