Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] add missing arguments for PIT scenarios #16872

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[6.16.z] add missing arguments for PIT scenarios #16872

merged 1 commit into from
Nov 6, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16665

Add missing deployment arguments for host deployment by merging with proper settings. This should fix PIT Installer scenarios. Credits @ogajduse

@Satellite-QE Satellite-QE requested a review from a team as a code owner November 5, 2024 17:02
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 5, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py -k 'test_satellite_installation'

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9276
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/installer/test_installer.py -k test_satellite_installation --external-logging
Test Result : ========== 1 passed, 23 deselected, 36 warnings in 1490.82s (0:24:50) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 5, 2024
vsedmik
vsedmik approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks CPed correctly, PRT passed.

@vsedmik vsedmik merged commit 1e1b6b7 into 6.16.z Nov 6, 2024
16 checks passed
@vsedmik vsedmik deleted the cherry-pick-6.16.z-1be376372f8d5927ce063f84dffaf8935fb0ef14 branch November 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@rmynar rmynar

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @vsedmik @rmynar