Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend manifest labels test case with manifest_lists #16878

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Nov 6, 2024

Problem Statement

  1. Manifest labels, annotations and other flags were added to manifest lists too (previously they were added to manifests only). After container-type repo sync they should be indexed and returned by API.
  2. Also the labels and flags should be indexed during upgrade from 6.16 to 6.17.
  3. We are going to have a new-style approach to the upgrade scenarios.

Solution

  1. We already have a test case to check the fields in manifests. This PR extends the test case to check the same in manifest lists too.
  2. We already have similar test case in upgrade scenarios. This PR extends the test case, and
  3. adds new one as an upgrade new-styler using the share_resource approach.
  4. Here we also update the CODEOWNERS file with the new upgrade files.

Related Issues

https://issues.redhat.com/browse/SAT-27490

PRT test Cases example

Requires
Katello/katello#11172
SatelliteQE/nailgun#1240 (merged)

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k synchronize_docker_repo_with_manifest_labels
Katello:
  katello: 11172

For the new-style upgrade scenario we need to wait for the 11172 being packed in next snap.

trigger: test-robottelo
pytest: tests/new_upgrades/test_repository.py -k test_container_repo_sync
env:
  BROKER_SSH_BACKEND: hussh

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 6, 2024
@vsedmik vsedmik self-assigned this Nov 6, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 6, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k synchronize_docker_repo_with_manifest_labels
nailgun: 1240
Katello:
katello: 11172

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9299
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_repository.py -k synchronize_docker_repo_with_manifest_labels --external-logging
Test Result : ========= 167 deselected, 180 warnings, 2 errors in 4768.37s (1:19:28) =========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 6, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9300
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_repository.py -k synchronize_docker_repo_with_manifest_labels --external-logging
Test Result : ========= 167 deselected, 180 warnings, 2 errors in 5364.90s (1:29:24) =========

@vsedmik vsedmik requested a review from synkd November 11, 2024 11:17
@vsedmik vsedmik marked this pull request as ready for review November 11, 2024 11:17
@vsedmik vsedmik requested review from a team as code owners November 11, 2024 11:17
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing specifically for the change to the new upgrade format, everything looks good there.

@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 18, 2024

Eh, I need to update the "legacy upgrade" test too since this would break it.

@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 18, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k synchronize_docker_repo_with_manifest_labels

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9390
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k synchronize_docker_repo_with_manifest_labels --external-logging
Test Result : ========= 2 passed, 167 deselected, 204 warnings in 618.05s (0:10:18) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Nov 18, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 18, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_repository.py -k test_container_repo_sync
env:
  BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9391
Build Status: UNSTABLE
PRT Comment: pytest tests/new_upgrades/test_repository.py -k test_container_repo_sync --external-logging
Test Result : ========== 1 failed, 1 deselected, 20 warnings in 2183.02s (0:36:23) ===========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Nov 18, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 18, 2024

PRT failed since 6.15.z has been used for pre-upgrade deploy and nailgun implements the docker_manifests since 6.16.z. We could CP it but it won't help to this test case since it's a 6.16 -> 6.17 thing.

@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 18, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_repository.py -k test_container_repo_sync
env:
  BROKER_SSH_BACKEND: hussh
  ROBOTTELO_upgrade__from_version: '6.16'
  ROBOTTELO_upgrade__to_version: '6.17'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9392
Build Status: UNSTABLE
PRT Comment: pytest tests/new_upgrades/test_repository.py -k test_container_repo_sync --external-logging
Test Result : ========== 1 failed, 1 deselected, 20 warnings in 1226.52s (0:20:26) ===========

@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 18, 2024

trigger: test-robottelo
pytest: tests/new_upgrades/test_repository.py -k test_container_repo_sync
env:
  BROKER_SSH_BACKEND: hussh
  ROBOTTELO_upgrade__from_version: '6.16'
  ROBOTTELO_upgrade__to_version: 'stream'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9396
Build Status: SUCCESS
PRT Comment: pytest tests/new_upgrades/test_repository.py -k test_container_repo_sync --external-logging
Test Result : ========== 1 passed, 1 deselected, 19 warnings in 1704.97s (0:28:24) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 18, 2024
@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 18, 2024
@pondrejk pondrejk merged commit 1b3cfd4 into SatelliteQE:master Nov 20, 2024
15 checks passed
@vsedmik vsedmik deleted the extend-manifest-labels branch November 22, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants