Post deployments for content hosts, starting with FIPS #16903
Conversation
jyejare
force-pushed
the
post_deployments_fips
branch
from
60620c5 to
6cadb2e
Compare
jyejare
added
CherryPick
pytest_fixtures/core/contenthosts.py
Outdated
| def run_post_deployments(request, host): | ||
| """Execute post deploy""" | ||
| params = {} | ||
| if hasattr(request, 'param'): | ||
| params = request.param | ||
| if 'fips' in params.get('rhel_version'): | ||
| Broker().execute(workflow='enable-fips', target_host=host.name) |
There was a problem hiding this comment.
Did you consider putting this logic into ContentHost.setup method? If we would go that route, we would need to pass params['rhel_version'] (as a metadata) to broker through the host_conf method, so we can read it later on in the setup method. This is something we already do with blank=True.
There was a problem hiding this comment.
Did not consider that for sure, but It was a perfect suggestion.
I choose this route to keep the content host procedures native to content host fixtures in this module for easy understanding and debug.
But anyways now we had to close the PR :(
There was a problem hiding this comment.
@ogajduse We are again allowed to go this path after some brainstorming in the Lab team. I have addressed your comment and its subject to verification by running PRT post enable-fips WF merged in Tower.
jyejare
force-pushed
the
post_deployments_fips
branch
2 times, most recently
from
c895af9 to
aa21a03
Compare
jyejare
force-pushed
the
post_deployments_fips
branch
from
aa21a03 to
2105fab
Compare
| deploy_rhel_version: '9' | ||
| target_memory: 1536 MiB | ||
| target_cores: 1 | ||
| rhel10_fips: |
There was a problem hiding this comment.
| rhel10_fips: | |
| rhel10: |
| deploy_rhel_version: '9' | ||
| target_memory: 1536 MiB | ||
| target_cores: 1 | ||
| container: | ||
| container_host: ubi9:latest | ||
| rhel9_fips: | ||
| vm: | ||
| workflow: deploy-base-rhel-fips | ||
| workflow: deploy-rhel | ||
| deploy_rhel_version: '9' |
There was a problem hiding this comment.
| deploy_rhel_version: '9' | |
| deploy_rhel_version: '9' | |
| deploy_fips_enable: true |
| target_memory: 1536 MiB | ||
| target_cores: 1 |
There was a problem hiding this comment.
target_cores and target_memory options can be removed since it won't do anything for VM deployed in RHOS
| @@ -37,6 +37,9 @@ def host_conf(request): | |||
| deploy_kwargs = settings.content_host.get(_rhelver).to_dict().get('vm', {}) | |||
| if network := params.get('network'): | |||
| deploy_kwargs.update({'deploy_network_type': network}) | |||
| # Post_deploy_workflow_runs to be run in ContentHost.setup method | |||
| if 'fips' in params.get('rhel_version'): | |||
There was a problem hiding this comment.
| if 'fips' in params.get('rhel_version'): | |
| if 'rhel10_fips' in params.get('rhel_version'): |
Problem Statement
enable-fipsWF for any RHELSolution
enable_fipsWF should run on the given host hence supporting 2 steps FIPS Content hostRelated Issues