Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API e2e test to use RegistrationCommand entity to register #16914

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update API e2e test to use RegistrationCommand entity to register #16914

merged 1 commit into from
Nov 19, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Nov 14, 2024 •
edited
Loading

Problem Statement

API e2e test to use hammer to register instead of API/nailgun

Solution

  • Update API e2e test to use RegistrationCommand entity to register
  • Also cover the package install during registration process with RegistrationCommand entity

Related Issues

SatelliteQE/nailgun#1225

@Gauravtalreja1 Gauravtalreja1 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 14, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Nov 14, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner November 14, 2024 07:47
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_api_endtoend.py -k test_positive_end_to_end
nailgun: 1225

@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Nov 14, 2024
Merged
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9359
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/endtoend/test_api_endtoend.py -k test_positive_end_to_end --external-logging
Test Result : ========== 1 passed, 5 deselected, 18 warnings in 5434.66s (1:30:34) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 14, 2024
@Gauravtalreja1 Gauravtalreja1 force-pushed the api-e2e-api-registration branch from a776332 to 9b952c1 Compare November 14, 2024 17:31
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_api_endtoend.py -k test_positive_end_to_end

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 14, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9367
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/endtoend/test_api_endtoend.py -k test_positive_end_to_end --external-logging
Test Result : ========== 1 passed, 5 deselected, 18 warnings in 1510.28s (0:25:10) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 14, 2024
@shweta83
Copy link
Contributor

shweta83 commented Nov 15, 2024 •
edited
Loading

@Gauravtalreja1 Can you please update the description of the PR and commit message to add package option in registration command since you added that in the test. Rest all looks good.

shweta83
shweta83 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, pending minor comment

@Gauravtalreja1
Copy link
Collaborator Author

@shweta83 Sure, I updated the description for future references, but, I would differ from adding it to the commit message since it will unnecessarily make it longer

lhellebr
lhellebr approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the PR description please so it's not confusion what you're changing to what. Otherwise, ACK.

@shubhamsg199 shubhamsg199 merged commit f56fd6b into SatelliteQE:master Nov 19, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@Gauravtalreja1 @web-flow
Update API e2e test to use RegistrationCommand entity to register (#1…
24ed57c 
…6914)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit f56fd6b)
This was referenced Nov 19, 2024
Merged
Open
Open
@Satellite-QE Satellite-QE mentioned this pull request Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@shweta83 shweta83 shweta83 approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gauravtalreja1 @Satellite-QE @shweta83 @lhellebr @shubhamsg199