[6.14.z] Rely on dynaconf to render the config based on is_ipv6 setting #16925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 388a0ec)
Satellite-QE
added
6.14.z
ogajduse
deleted the
cherry-pick-6.14.z-388a0ec6adeb74148e3225565969a57a4f6e4af0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #16886
Problem Statement
The REPOS section of the config contains
-ipv4hostnames despite theis_ipv6setting being set toTrue. This happens because we are looping through the non-templatized/non-formatted configuration loaded by the dynaconf YAML loader:robottelo/robottelo/utils/url.py
Line 46 in a79da44
Since the
REPOSconfig section contains several templates, either@formator@jinja, injecting a string containing-ipv4, and since our algorithm uses the raw config file value loaded by the YAML loader, we are not able to detect this case and change these URLs and hostnames to-ipv6.Solution
The proposed solution is to shift to a different approach - from mutating settings by an algorithm in robottelo to creating a self-contained configuration structure and including IPv4 and IPv6 URLs and hostnames in the config. Based on the
IS_IPV6setting, templatize the value of the actual hostname/URL config field.Related Issues
https://issues.redhat.com/browse/SAT-29304
satellite-jenkins!1545