Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and extend the RH recommended repos case #16930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Nov 15, 2024

Problem Statement

The "recommended repos" test case has been failing for a while, blocking us from seeing product bugs. Also some of the recommended repos has changed over a time.

Solution

This PR updates and extends the test case. It could be backported with minor changes in the constants to 6.16.z and 6.15.z, I would handle the changes in the cherry-picks.

At this time it is expected to fail in stream. It must keep failing until Katello/katello#11205 is baked in stream AND the 6.17 repos are added to match the Satellite version.

Related Issues

https://issues.redhat.com/browse/SAT-29446
https://issues.redhat.com/browse/SAT-29448

PRT test Cases example

requires SatelliteQE/airgun#1631

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k recommended_repos

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 15, 2024
@vsedmik vsedmik self-assigned this Nov 15, 2024
@vsedmik vsedmik requested review from a team as code owners November 15, 2024 18:40
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 15, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k recommended_repos

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9373
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k recommended_repos --external-logging
Test Result : ========== 1 failed, 28 deselected, 38 warnings in 1726.67s (0:28:46) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 15, 2024
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👏

I have some queries about EUS repos from RECOMMENDED_REPOS, and want to clear understanding, but this can be discuss in virtually.

@LadislavVasina1
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k recommended_repos

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9376
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k recommended_repos --external-logging
Test Result : ========== 1 failed, 28 deselected, 38 warnings in 798.92s (0:13:18) ===========

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants