Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix some long failing subscription tests #16940

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[6.15.z] Fix some long failing subscription tests #16940

merged 1 commit into from
Nov 20, 2024

Conversation

LadislavVasina1
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 commented Nov 18, 2024 •
edited
Loading

This PR fixes 2 long failing subscription tests.
One of them was missing the required function parameter (lce_id) thus was failing.
For second UI test I have upgraded the fixture and UI test logic to used legacy content host's UI.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py::test_positive_subscription_status_disabled_golden_ticket  tests/foreman/api/test_subscription.py::test_sca_end_to_end

@LadislavVasina1 LadislavVasina1 added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 18, 2024
@LadislavVasina1 LadislavVasina1 requested review from vsedmik and a team November 18, 2024 13:22
@LadislavVasina1 LadislavVasina1 self-assigned this Nov 18, 2024
@LadislavVasina1
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py::test_positive_subscription_status_disabled_golden_ticket  tests/foreman/api/test_subscription.py::test_sca_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9385
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py::test_positive_subscription_status_disabled_golden_ticket  tests/foreman/api/test_subscription.py::test_sca_end_to_end --external-logging
Test Result : ================== 2 passed, 68 warnings in 840.77s (0:14:00) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 18, 2024
chris1984
chris1984 reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, left 1 comment.

tests/foreman/ui/test_subscription.py
def golden_ticket_host_setup(function_entitlement_manifest_org, module_target_sat):
org = function_entitlement_manifest_org
@pytest.fixture
def golden_ticket_host_setup(function_sca_manifest_org, module_target_sat):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway we can get away from this name and switch it to something named more after SCA?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point @chris1984. I just guess we would want to make the change in master first and back-propagate it to streams. The downside might be discontinuity in test results history, but that's probably not so important for a long failing test.

vsedmik
vsedmik approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me.

@LadislavVasina1 LadislavVasina1 requested a review from a team November 19, 2024 23:00
@pondrejk pondrejk merged commit c4a0d78 into SatelliteQE:6.15.z Nov 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 left review comments

@vsedmik vsedmik vsedmik approved these changes

Assignees

@LadislavVasina1 LadislavVasina1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LadislavVasina1 @Satellite-QE @chris1984 @vsedmik @pondrejk