Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] Create fake galaxy.yml to make the FAM Makefile happy #16941

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16936

Problem Statement

The upstream FAM Makefile expects a galaxy.yml to read some data from it, as it exists in git.
A release doesn't include galaxy.yml (it's the input to the release process).
But we call the Makefile on a released version, and this produces irritating output on stderr (without being an actual error).

Solution

The data in the file is unused, but not being able to load it produces
errors in the logs and is confusing when searching for an actual problem
during testing. Fake a file to silence the errors.

Related Issues

The data in the file is unused, but not being able to load it produces
errors in the logs and is confusing when searching for an actual problem
during testing.

(cherry picked from commit c45e681)
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 18, 2024 15:39
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 18, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/sys/test_fam.py

@jameerpathan111 jameerpathan111 enabled auto-merge (squash) November 18, 2024 15:40
@jameerpathan111 jameerpathan111 merged commit f42bc8f into 6.16.z Nov 18, 2024
13 of 14 checks passed
@jameerpathan111 jameerpathan111 deleted the cherry-pick-6.16.z-c45e6816b663689d726a7e8aa377082e3afeb813 branch November 18, 2024 15:53
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9388
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/sys/test_fam.py --external-logging
Test Result : =========== 14 failed, 96 passed, 352 warnings in 5297.38s (1:28:17) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants